upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-03-10 18:40:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
kubernetes/pkg/util/mount
History
Kubernetes Submit Queue 2aced6d9e4
Merge pull request #63248 from andyzhangx/formatAndMount-windows 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix formatAndMount func issue on Windows

**What this PR does / why we need it**:
disk format code is missing in formatAndMount func on Windows, currently it only has mount related code:
b87a392b1a/pkg/util/mount/mount_windows.go (L356-L377)

format code is now here, which is not correct(invoked in `azuredisk.WaitForAttach` operation, it's not correct, these code should be in `formatAndMount` func and invoked by `MountDevice` operation finally)
b87a392b1a/pkg/volume/azure_dd/azure_common_windows.go (L100-L117)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #63236 

**Special notes for your reviewer**:
This is the first PR,  in second PR, I will remove disk format code in azure_common_windows.go
b87a392b1a/pkg/volume/azure_dd/azure_common_windows.go (L100-L117)

Also need to mention that there would not be issue if  following command invoked twice(by `WaitForAttach` and `formatAndMount`)
```
Get-Disk -Number 4 | Where partitionstyle -eq 'raw' | Initialize-Disk -PartitionStyle MBR -PassThru  | New-Partition -AssignDriveLetter -UseMaximumSize | Format-Volume -FileSystem ntfs -Confirm:$false
```
**Release note**:

```
fix formatAndMount func issue on Windows
```

/sig windows
/assign @rootfs 
cc @msau42
2018-06-01 21:25:57 -07:00
..
BUILD Nsenter unit tests 2018-05-23 10:21:21 +02:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
exec.go Add Exec interface to VolumeHost 2017-08-14 12:16:25 +02:00
exec_mount.go Enhance ExistsPath check 2018-05-23 10:21:20 +02:00
exec_mount_test.go Enhance ExistsPath check 2018-05-23 10:21:20 +02:00
exec_mount_unsupported.go Enhance ExistsPath check 2018-05-23 10:21:20 +02:00
fake.go Enhance ExistsPath check 2018-05-23 10:21:20 +02:00
mount.go Change SafeMakeDir to resolve symlinks in mounter implementation 2018-05-23 10:21:20 +02:00
mount_linux.go Merge pull request #63143 from jsafrane/containerized-subpath 2018-06-01 12:12:19 -07:00
mount_linux_test.go Merge pull request #63143 from jsafrane/containerized-subpath 2018-06-01 12:12:19 -07:00
mount_unsupported.go Enhance ExistsPath check 2018-05-23 10:21:20 +02:00
mount_windows.go Merge pull request #63248 from andyzhangx/formatAndMount-windows 2018-06-01 21:25:57 -07:00
mount_windows_test.go add formatAndMount unit test on Windows 2018-05-21 05:48:04 +00:00
nsenter_mount.go Merge pull request #63143 from jsafrane/containerized-subpath 2018-06-01 12:12:19 -07:00
nsenter_mount_test.go Nsenter unit tests 2018-05-23 10:21:21 +02:00
nsenter_mount_unsupported.go Pass Nsenter to NsenterMounter and NsenterWriter 2018-05-23 10:21:21 +02:00
OWNERS add andyzhangx as Reviewer 2018-04-16 07:13:15 +00:00
safe_format_and_mount_test.go When creating ext3/ext4 volume, pass -m0 to mkfs in order to disable the 2018-05-21 12:43:57 -04:00