mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-03-02 21:50:39 -05:00
1ba9202cd8
Automatic merge from submit-queue Conversionlint **What this PR does / why we need it**: This PR adds a comment placeholder for the exported or public functions in conversion generator files. Such functions without a comment results into golint failure in various generated files. The changes in this patch takes care of about 36 related lint failures. Given below is an example lint error, zz_generated.conversion.go:91:1: exported function Convert_v1alpha1_Binding_To_servicecatalog_Binding should have comment or be unexported **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Considering minor changes no issue is created. **Special notes for your reviewer**: Hello, I am trying to fix golint failures as we see them in the kubernetes-incubator/service-catalog project. I have separate PRs opened for lint issues related to other generator code which are in separate libraries like gengo. Thanks! **Release note**: ```release-note ``` |
||
|---|---|---|
| .. | ||
| endpoints | ||
| pod | ||
| service | ||
| validation | ||
| backward_compatibility_test.go | ||
| BUILD | ||
| conversion.go | ||
| conversion_test.go | ||
| defaults.go | ||
| defaults_test.go | ||
| doc.go | ||
| generate.go | ||
| generated.pb.go | ||
| generated.proto | ||
| helpers.go | ||
| helpers_test.go | ||
| meta.go | ||
| OWNERS | ||
| ref.go | ||
| register.go | ||
| resource_helpers.go | ||
| resource_helpers_test.go | ||
| types.generated.go | ||
| types.go | ||
| types_swagger_doc_generated.go | ||
| zz_generated.conversion.go | ||
| zz_generated.deepcopy.go | ||
| zz_generated.defaults.go | ||