mirror of
https://github.com/kubernetes/kubernetes.git
synced 2026-06-15 12:30:45 -04:00
3616ffa284
GetAllLocalAddressesExcept previously iterated over net.Interfaces() and called iface.Addrs() for each interface. iface.Addrs() internally performs a full RTM_GETADDR netlink dump for the entire node and then filters in user space. With many interfaces and many addresses (for example tens of thousands of ClusterIPs bound to kube-ipvs0) the cost is O(N_interfaces * N_addresses) and dominates syncProxyRules latency. This change replaces the per-interface loop with a single netlink.AddrList(nil, unix.AF_UNSPEC) call that dumps all addresses on the node in one RTM_GETADDR request, then filters by LinkIndex in user space. This makes the call O(N_addresses) and avoids the per-interface fan-out. On a production node with 251 interfaces and 19757 addresses, this reduces GetAllLocalAddressesExcept latency from 34.8s to 60ms (~705x).
113 lines
2.6 KiB
Go
113 lines
2.6 KiB
Go
//go:build linux
|
|
|
|
/*
|
|
Copyright The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package ipvs
|
|
|
|
import (
|
|
"net"
|
|
"reflect"
|
|
"sort"
|
|
"testing"
|
|
|
|
"github.com/vishvananda/netlink"
|
|
netutils "k8s.io/utils/net"
|
|
)
|
|
|
|
// addr builds a netlink.Addr suitable for use in filterAddrsExcept tests.
|
|
func addr(ip string, mask, linkIndex int) netlink.Addr {
|
|
parsed := netutils.ParseIPSloppy(ip)
|
|
bits := 32
|
|
if parsed.To4() == nil {
|
|
bits = 128
|
|
}
|
|
return netlink.Addr{
|
|
IPNet: &net.IPNet{IP: parsed, Mask: net.CIDRMask(mask, bits)},
|
|
LinkIndex: linkIndex,
|
|
}
|
|
}
|
|
|
|
func collectIPs(addrs []net.Addr) []string {
|
|
out := make([]string, 0, len(addrs))
|
|
for _, a := range addrs {
|
|
ipnet, ok := a.(*net.IPNet)
|
|
if !ok {
|
|
continue
|
|
}
|
|
out = append(out, ipnet.IP.String())
|
|
}
|
|
sort.Strings(out)
|
|
return out
|
|
}
|
|
|
|
func TestFilterAddrsExcept(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
addrs []netlink.Addr
|
|
devIndex int
|
|
expected []string
|
|
}{
|
|
{
|
|
name: "filters addresses on dev by LinkIndex",
|
|
addrs: []netlink.Addr{
|
|
addr("192.168.1.10", 24, 2),
|
|
addr("10.233.0.1", 32, 10),
|
|
addr("10.233.0.2", 32, 10),
|
|
addr("10.233.0.3", 32, 10),
|
|
addr("fd00::1", 128, 2),
|
|
},
|
|
devIndex: 10,
|
|
expected: []string{"192.168.1.10", "fd00::1"},
|
|
},
|
|
{
|
|
name: "keeps everything when no address belongs to dev",
|
|
addrs: []netlink.Addr{
|
|
addr("192.168.1.10", 24, 2),
|
|
addr("10.0.0.1", 24, 3),
|
|
},
|
|
devIndex: 10,
|
|
expected: []string{"10.0.0.1", "192.168.1.10"},
|
|
},
|
|
{
|
|
name: "drops nil IPNet defensively",
|
|
addrs: []netlink.Addr{
|
|
{IPNet: nil, LinkIndex: 2},
|
|
addr("192.168.1.10", 24, 2),
|
|
},
|
|
devIndex: 10,
|
|
expected: []string{"192.168.1.10"},
|
|
},
|
|
{
|
|
name: "empty input",
|
|
addrs: nil,
|
|
devIndex: 10,
|
|
expected: []string{},
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
got := collectIPs(filterAddrsExcept(tc.addrs, tc.devIndex))
|
|
want := tc.expected
|
|
if want == nil {
|
|
want = []string{}
|
|
}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Errorf("filterAddrsExcept(_, %d) = %v, want %v", tc.devIndex, got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|