Commit graph

6936 commits

Author SHA1 Message Date
Edwin Hernandez
fa9071302f
Adding metrics for Maxunavailable feature in StatefulSet (#130951)
* adding maxunavailable_violation metric

added metric to list of stable metrics

changed when metric gets incremented

addressed comments

fixed stable metrics list

* Update pkg/controller/statefulset/metrics/metrics.go

Co-authored-by: Filip Křepinský <fkrepins@redhat.com>

* Update the metric and log verbosity level

* Address false positives metric count

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* Implement maxUnavailable and UnavailableReplicas metrics

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix lint fmt

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* update tests

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* se metrics to 1 as a default

* log for true validation only and update func sig.

* Move maxUnavailable metric to the updateStatefulSetStatus

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* change metrics stability level to Alpha

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix unit test

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* fix linting issue

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

* Address code review feedback

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

---------

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>
Co-authored-by: Filip Křepinský <fkrepins@redhat.com>
Co-authored-by: Heba Elayoty <heelayot@microsoft.com>
2025-09-17 05:34:14 -07:00
Kubernetes Prow Robot
69e92c6827
Merge pull request #134022 from aditigupta96/cleanup-waitfornamedcachesync
refactor(controller): Use context-aware WaitForNamedCacheSync in resourcequota and HPA tests
2025-09-16 17:18:16 -07:00
Kubernetes Prow Robot
d03d25f47c
Merge pull request #133985 from aditigupta96/api-waitfornamedcachesync-with-context
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/
2025-09-16 17:18:09 -07:00
Aditi Gupta
af231d2153 Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/ 2025-09-16 14:51:34 -07:00
Kubernetes Prow Robot
12ddfaa5c7
Merge pull request #133984 from aditigupta96/add-context-to-waitfornamedcachesync
Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/garbagecollector
2025-09-16 13:48:10 -07:00
Aditi Gupta
1ce12710ec refactor(controller): Use context-aware WaitForNamedCacheSync in resourcequota and HPA tests 2025-09-12 12:37:54 -07:00
Kubernetes Prow Robot
118e833a0d
Merge pull request #133687 from soltysh/drop_PodIndexLabel
Drop PodIndexLabel after the feature GA-ed in 1.32
2025-09-12 07:30:11 -07:00
Kubernetes Prow Robot
44544abdc7
Merge pull request #133612 from michaelasp/discoveryCheck
feat: Add discovery check to SVM to ensure migration doesn't get stuck
2025-09-11 18:32:07 -07:00
Maciej Szulik
46cc610e6f
Drop PodIndexLabel after the feature GA-ed in 1.32
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
2025-09-11 19:32:48 +02:00
Kubernetes Prow Robot
26b246ae66
Merge pull request #133191 from Jefftree/rev
Add jefftree to OWNERS
2025-09-11 07:06:11 -07:00
Kubernetes Prow Robot
bb12fee4c1
Merge pull request #133904 from aditigupta96/feat-auth-trust-wait-context
Change WaitForNamedCacheSync to WaitForNamedCacheSyncWithContext
2025-09-10 18:48:02 -07:00
Aditi Gupta
dfcadb4f89 Replace WaitForNamedCacheSync with WaitForNamedCacheSyncWithContext in pkg/controller/garbagecollector 2025-09-10 13:08:27 -07:00
Kubernetes Prow Robot
a8905a154b
Merge pull request #133179 from nmn3m/fix-strings-title
Replace deprecated strings.Title with cases.Title
2025-09-09 05:53:30 -07:00
Huan Yan
7aa6cabd63 fix typo for forceDetachTimeoutExpired 2025-09-07 16:37:34 +08:00
Michael Aspinwall
1a0813598b Update SVM Discovery checks in response to jpbetz and stlaz 2025-09-05 20:33:05 +00:00
Aditi Gupta
7d14367f57 Change WaitForNamedCacheSync to WaitForNamedCacheSyncWithContext.
This is part of the ongoing effort to adopt contextual logging
and utilities throughout the codebase.

Contributes to  #126379

Signed-off-by: Aditi Gupta <aditigpta@google.com>
2025-09-05 18:49:31 +00:00
Michael Aspinwall
21359d7b1f Switch to resourceVersion controller 2025-09-04 18:17:00 +00:00
Omer Aplatony
fbd33bd6b3 hpa: prevent integer overflow in external metrics sum
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2025-09-04 08:36:53 +00:00
Kubernetes Prow Robot
1bcfd5cee7
Merge pull request #133741 from kincoy/hpa-cleanup-redundant-casts
cleanup: remove redundant type conversions in podautoscaler
2025-09-01 04:35:20 -07:00
Kubernetes Prow Robot
5c107f08e9
Merge pull request #133708 from ingvagabund/podautoscaler-dont-print-panic
fix(controller/podautoscaler): do not print panic when .status.lastScaleTime is not set
2025-09-01 04:35:13 -07:00
Nour
72847ee1f7
Replace deprecated strings.Title with cases.Title 2025-08-30 18:16:59 +03:00
Michael Aspinwall
e1218922db Add unit tests to isResourceUpdatable 2025-08-28 21:04:59 +00:00
Kubernetes Prow Robot
6b33567f9b
Merge pull request #133684 from soltysh/drop_StatefulSetAutoDeletePVC
Drop StatefulSetAutoDeletePVC after the feature GA-ed in 1.32
2025-08-28 10:49:15 -07:00
Maciej Szulik
09e357d31f
Drop StatefulSetAutoDeletePVC after the feature GA-ed in 1.32
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
2025-08-28 13:35:16 +02:00
kincoy
12a784b46b cleanup: remove redundant type conversions in podautoscaler
Signed-off-by: kincoy <kincoyao@gmail.com>
2025-08-28 14:28:57 +08:00
Kubernetes Prow Robot
e8fb05e8a0
Merge pull request #133686 from soltysh/drop_CronJobsScheduledAnnotation
Drop CronJobsScheduledAnnotation after the feature GA-ed in 1.32
2025-08-27 20:24:28 -07:00
Kubernetes Prow Robot
b8f5561ab7
Merge pull request #133425 from jsafrane/selinux-e2e-driver
Fix SELinux label comparison
2025-08-27 17:18:56 -07:00
Kubernetes Prow Robot
5742171781
Merge pull request #133415 from AadiDev005/optimize-calculate-pod-requests
HPA: optimize calculatePodRequests for specific container lookups
2025-08-27 17:18:34 -07:00
Kubernetes Prow Robot
dc348645a9
Merge pull request #133116 from 264nm/fix-approved-unissued-csrs
Fix: Add garbage collection to handle Approved-Unissued CSRs
2025-08-27 16:05:34 -07:00
Kubernetes Prow Robot
1c778ab972
Merge pull request #132503 from LoganGoogle/remove-redundant-code
Remove redundant MilliValue call in GetRawMetric for podautoscaler
2025-08-27 14:53:58 -07:00
Kubernetes Prow Robot
4b818b45e4
Merge pull request #132477 from xigang/daemonset_missscheduled
Fix DaemonSet misscheduled status not updating on node taint changes
2025-08-27 14:53:51 -07:00
Omer Aplatony
b9a8dffa51
Fix replicaCount calculation exceeding max int32 (#126979)
* Fix replicaCount calculation exceeding max int32

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* Add test for scaling up with overflow

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

---------

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2025-08-27 14:53:15 -07:00
Jan Safranek
75d04e6c7b Add a note about Conflicts return value 2025-08-26 15:04:21 +02:00
Jan Chaloupka
83da6f1a87 fix(controller/podautoscaler): do not print panic when .status.lastScaleTime is not set 2025-08-26 14:18:54 +02:00
Maciej Szulik
a0a43e5f80
Drop CronJobsScheduledAnnotation after the feature GA-ed in 1.32
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
2025-08-25 14:00:35 +02:00
264nm
9c8e03a40b gofmt cleaner.go 2025-08-25 17:36:35 +10:00
264nm
8b760704fc fix(cleaner.go): exit early on check of CSR issue state 2025-08-22 12:37:55 +10:00
Michael Aspinwall
3bdaeea215 feat: Add discovery check to SVM to ensure migration doesn't get stuck 2025-08-20 16:32:15 +00:00
aditya
bb6a0ea6b2 HPA: optimize calculatePodRequests for specific container lookups
- Add early exit when specific container is found in calculatePodRequestsFromContainers
- Add error handling for non-existent containers following existing patterns
- Maintain all existing functionality for pod-level resources and feature gates
- Include comprehensive function documentation

The optimization eliminates unnecessary container iterations when HPA targets
specific containers, providing significant performance improvements for pods
with many containers while preserving full backward compatibility
2025-08-20 19:13:00 +05:30
264nm
ebf3d814f4 Fix(cleaner.go): Add GC to handle Approved-Unissued CSRs 2025-08-20 10:55:07 +10:00
xigang
3eb69eb852 Fix DaemonSet misscheduled status not updating on node taint changes
Signed-off-by: xigang <wangxigang2014@gmail.com>
2025-08-12 07:52:40 +08:00
Jan Safranek
97edb4d5e4 Fix SELinux label comparison
The comparison of SELinux labels in KCM tolerates missing fields - the
operating system is going to default them from its defaults, but in KCM we
don't know what the defaults are.

But the OS won't default the last component, "level", which includes also
categories. Make sure that labels with a level set conflicts with level "",
that's what will conflict on the OS too.
2025-08-08 10:13:19 +02:00
Jefftree
7242ddd937 Add jefftree to OWNERS 2025-08-04 19:12:13 +00:00
Sunyanan Choochotkaew
7f052afaef
KEP 5075: implement scheduler
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
2025-07-30 09:52:49 +09:00
Luiz Oliveira
7fbf63a23f
HPA support for pod-level resource specifications (#132430)
* HPA support for pod-level resource specifications

* Add e2e tests for HPA support for pod-level resource specifications
2025-07-29 09:02:26 -07:00
Eddie
727a6e6db5
Reject pod when attachment limit is exceeded (#132933)
* Reject pod when attachment limit is exceeded

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Record admission rejection

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Fix pull-kubernetes-linter-hints

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Fix AD Controller unit test failure

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Consolidate error handling logic in WaitForAttachAndMount

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Improve error context

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Update admissionRejectionReasons to include VolumeAttachmentLimitExceededReason

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Update status message

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Add TestWaitForAttachAndMountVolumeAttachLimitExceededError unit test

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Add e2e test

Signed-off-by: Eddie Torres <torredil@amazon.com>

* Fix pull-kubernetes-linter-hints

Signed-off-by: Eddie Torres <torredil@amazon.com>

---------

Signed-off-by: Eddie Torres <torredil@amazon.com>
2025-07-24 17:58:54 -07:00
Kubernetes Prow Robot
a5d8ab60ef
Merge pull request #132632 from sdowell/gc-rv-race
fix: add RV check on GC delete calls
2025-07-24 17:58:47 -07:00
Kubernetes Prow Robot
7912e5fd67
Merge pull request #131549 from carlory/KEP-3751-GA
[Kep-3751] Promote VolumeAttributesClass to GA
2025-07-24 16:44:27 -07:00
carlory
94bf8fc8a9 Promoted API VolumeAttributesClass and VolumeAttributesClassList to storage.k8s.io/v1.
Promoted feature-gate `VolumeAttributesClass` to GA (on by default)

Signed-off-by: carlory <baofa.fan@daocloud.io>
2025-07-25 01:53:59 +08:00
Patrick Ohly
5c4f81743c DRA: use v1 API
As before when adding v1beta2, DRA drivers built using the
k8s.io/dynamic-resource-allocation helper packages remain compatible with all
Kubernetes release >= 1.32. The helper code picks whatever API version is
enabled from v1beta1/v1beta2/v1.

However, the control plane now depends on v1, so a cluster configuration where
only v1beta1 or v1beta2 are enabled without the v1 won't work.
2025-07-24 08:33:45 +02:00