Graduates the ImageVolume feature gate to GA in v1.36, locked to enabled.
Changes:
- Add v1.36 GA entry with LockToDefault: true
- Remove +featureGate=ImageVolume annotations from API types
- Promote e2e test to conformance
- Add emulation versioning to disablement tests
- Update conformance test metadata
- Remove feature-gated test expectations for ImageVolume PullPolicy
Ref: https://github.com/kubernetes/enhancements/issues/4639
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
When a test depends on multiple feature gates, the labels that are derived from
those feature gates (Alpha, Beta, OffByDefault) potentially get injected
multiple times. This makes test names unnecessarily long and less
readable. This is going to get worse when also considering feature gate
dependencies.
The same is true for other meta labels: it's convenient to inject e.g.
"Serial" only once in a context, but it's nicer when it then shows up as
"[Serial"] at the end of the test name.
Now they get collected while registering tests and only injected once at the
end of the leaf node (= ginkgo.It).
An additional benefit is that graduating features or promoting tests to
conformance doesn't change the order of the -list-tests output or the order in
testgrid because the changes are all at the end of the full test name. It also
helps in testgrid because more of the actual test name text is visible in the
rather narrow test name column.
A couple of tests were recently promoted to conformance
but they did not include a minimimum kubelet version,
which broke the kubeadm/kinder e2e jobs that skew the kubelet
version against the apiserver version.
Move the Endpoints API test from endpointslice.go to endpoints.go
Move the "kubernetes.default Service exists" and "kubernetes.default
endpoints exist" tests to apiserver.go, since (unlike the rest of
service.go/endpointslice.go) they aren't testing the behavior of the
Service/EndpointSlice/Endpoints APIs.
(No code changes, but fixed a typo in a comment.)
To backfill from removing spiffxp. I have been active in Kubernetes testing and conformance related discussions and PRs for 8+ years now and I am a SIG Testing TL. I'd lke to help review these additional directories.
I already approve the test/, including nearly all of the e2e tests and images, and the conformance image in particular for many years now.
