Kubernetes Prow Robot
2d4c2c90b2
Merge pull request #137377 from atombrella/feature/pkg_controlplane
...
pkg/controlplane: use modernize/slicescontains and modernize/rangeint
2026-04-23 03:20:25 +05:30
Abhijit Hoskeri
c07f3ebbde
Fix logspam in leaderelection controller.
...
If the reconcileElectionStep function returns `noRequeue, nil`, it causes log
spam from apiserver. This is because HandleErrorWithContext regardless of
error value. Skip logging if error is nil.
Also, tag the log message with the involved lease object name.
```
...
{"ts":1773796037662.8264,"logger":"UnhandledError","caller":"leaderelection/leaderelection_controller.go:169","msg":"Failed to reconcile election step"}
{"ts":1773796038472.465,"logger":"UnhandledError","caller":"leaderelection/leaderelection_controller.go:169","msg":"Failed to reconcile election step"}
...
```
2026-03-17 18:05:20 -07:00
ChengHao Yang
1360b939cf
Use contextual logging in leaderelection controller
...
Replace deprecated logging and wait APIs with their context-aware
alternatives in pkg/controlplane/controller/leaderelection/:
- utilruntime.HandleCrash -> HandleCrashWithContext
- utilruntime.HandleError -> HandleErrorWithContext
- cache.WaitForCacheSync -> WaitForNamedCacheSyncWithContext
- wait.Until -> wait.UntilWithContext
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
2026-03-07 00:26:53 +08:00
Mads Jensen
e9e2bc964a
pkg/controller: use modernize/slicescontains and modernize/rangeint
2026-03-03 19:12:38 +01:00
Aditi Gupta
f44279647b
refactor: Use WaitForNamedCacheSyncWithContext in core components
...
Signed-off-by: Aditi Gupta <aditigpta@google.com>
2025-09-18 11:34:28 -07:00
Jefftree
70794c4568
Add newline to fix owners fmt
2025-08-04 19:12:56 +00:00
Jefftree
7242ddd937
Add jefftree to OWNERS
2025-08-04 19:12:13 +00:00
Michael Aspinwall
1a59c250ea
feat: make CLE timers configurable
2025-06-25 16:38:50 +00:00
Jefftree
5ba4a90fda
Add LeaseCandidate v1beta1
2025-03-12 17:52:10 +00:00
Kubernetes Prow Robot
f13237a34e
Merge pull request #130735 from Jefftree/cle-lexo-check
...
CLE: Remove invalid emulated version and add lexographical order test
2025-03-11 19:47:59 -07:00
Jefftree
775b118a6d
Remove invalid emulated version and add lexographical order test
2025-03-11 21:00:48 +00:00
Kubernetes Prow Robot
ac05e1a48e
Merge pull request #130533 from Henrywu573/parall
...
Parallelize lease candidate ping
2025-03-11 12:47:53 -07:00
Henry Wu
5917343e45
Parallelize lease candidate ping
2025-03-06 01:02:45 -08:00
Henry Wu
ca9734afaa
Add third party strategy to the coordinate leader election integration test
2025-03-03 14:00:16 -08:00
Jefftree
1a1b566d61
Revert "LeaseCandidate alpha -> beta,"
...
This reverts commit ac7a95efb0
2025-03-01 14:14:19 +00:00
Jefftree
ac7a95efb0
LeaseCandidate alpha -> beta,
2025-02-27 17:50:36 +00:00
Jefftree
0ce7b688a6
v1alpha2 LeaseCandidate API
2024-11-08 02:27:19 +00:00
Jefftree
1ede4d8f15
Allow cle mutual exclusion lock to be reacquired
2024-11-05 21:01:03 +00:00
googs1025
b60cef2609
fix(leaderelection): nil check in OnStoppedLeading func
2024-10-04 00:26:06 +08:00
Dr. Stefan Schimanski
634c9cd135
Address comments
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-30 09:45:52 +02:00
Jefftree
d092513685
Use fake clock for controller/leaderelection:TestController
2024-07-29 19:36:53 +00:00
Dr. Stefan Schimanski
3987d850a4
kube-apiserver/leaderelection/test: clean up controller test
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-29 09:56:39 +02:00
Dr. Stefan Schimanski
b13aab9cf1
kube-apiserver/leaderelection: remove klog noise
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-29 09:56:05 +02:00
Jefftree
f173f0c58c
kube-apiserver/leaderelection/tests: fix test case PingTime should be ahead of RenewTime
2024-07-27 17:54:09 +00:00
Dr. Stefan Schimanski
b8045f98a4
kube-apiserver/leaderelection/tests: use fake clock
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-27 17:54:09 +00:00
Dr. Stefan Schimanski
8c971c5c15
kube-apiserver/leaderelection/test: fixing waiting for informer
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-27 17:54:08 +00:00
Dr. Stefan Schimanski
c7a1fa432a
Call non-blocking informerFactory.Start synchronously to avoid races
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-27 18:13:09 +02:00
Dr. Stefan Schimanski
87f40441d6
kube-apiserver/leaderelection: remove broken printf
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-26 09:27:05 +02:00
Jefftree
0c774d0b1f
Change PingTime to be persistent
2024-07-24 14:41:13 +00:00
Dr. Stefan Schimanski
a738daa88a
Review feedback: fix context handling in LeaseCandidateGCController
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-24 14:38:13 +00:00
Dr. Stefan Schimanski
15affefcab
Review feedback: handle non-kube strategy correctly
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-24 14:38:13 +00:00
Dr. Stefan Schimanski
a64418ba0a
Review feedback
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
2024-07-24 14:38:13 +00:00
Jefftree
fac7581640
feedback: leasecandidate clients
2024-07-24 14:38:12 +00:00
Jefftree
e0c6987ca8
add gc and improve testing
2024-07-24 14:38:11 +00:00
Jefftree
c47ff1e1a9
CLE controller and client changes
2024-07-24 14:38:11 +00:00
