From b92683326023161058873c1ce355395caee5ff7a Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Fri, 8 May 2026 23:57:04 -0400 Subject: [PATCH] Drop declarative minimum that is redundant with field type --- .../scheduling/v1alpha2/zz_generated.validations.go | 12 ------------ .../k8s.io/api/scheduling/v1alpha2/generated.proto | 2 -- staging/src/k8s.io/api/scheduling/v1alpha2/types.go | 2 -- 3 files changed, 16 deletions(-) diff --git a/pkg/apis/scheduling/v1alpha2/zz_generated.validations.go b/pkg/apis/scheduling/v1alpha2/zz_generated.validations.go index d020f1128cb..9889b3834bc 100644 --- a/pkg/apis/scheduling/v1alpha2/zz_generated.validations.go +++ b/pkg/apis/scheduling/v1alpha2/zz_generated.validations.go @@ -761,12 +761,6 @@ func Validate_PodGroupSpec( }); len(e) != 0 { errs = append(errs, e...) } - if e := validate.IfOption(ctx, op, fldPath, obj, oldObj, "WorkloadAwarePreemption", true, - func(ctx context.Context, op operation.Operation, fldPath *field.Path, obj, oldObj *int32) field.ErrorList { - return validate.Minimum(ctx, op, fldPath, obj, oldObj, -2147483648) - }); len(e) != 0 { - errs = append(errs, e...) - } return } oldVal := safe.Field(oldObj, @@ -1090,12 +1084,6 @@ func Validate_PodGroupTemplate( }); len(e) != 0 { errs = append(errs, e...) } - if e := validate.IfOption(ctx, op, fldPath, obj, oldObj, "WorkloadAwarePreemption", true, - func(ctx context.Context, op operation.Operation, fldPath *field.Path, obj, oldObj *int32) field.ErrorList { - return validate.Minimum(ctx, op, fldPath, obj, oldObj, -2147483648) - }); len(e) != 0 { - errs = append(errs, e...) - } return } oldVal := safe.Field(oldObj, diff --git a/staging/src/k8s.io/api/scheduling/v1alpha2/generated.proto b/staging/src/k8s.io/api/scheduling/v1alpha2/generated.proto index 73b3308e38b..73e0fa510ee 100644 --- a/staging/src/k8s.io/api/scheduling/v1alpha2/generated.proto +++ b/staging/src/k8s.io/api/scheduling/v1alpha2/generated.proto @@ -288,7 +288,6 @@ message PodGroupSpec { // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:immutable // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority - // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648 optional int32 priority = 7; } @@ -418,7 +417,6 @@ message PodGroupTemplate { // +k8s:ifDisabled("WorkloadAwarePreemption")=+k8s:forbidden // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority - // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648 optional int32 priority = 7; } diff --git a/staging/src/k8s.io/api/scheduling/v1alpha2/types.go b/staging/src/k8s.io/api/scheduling/v1alpha2/types.go index 1f84f2c43d3..d4ca4040344 100644 --- a/staging/src/k8s.io/api/scheduling/v1alpha2/types.go +++ b/staging/src/k8s.io/api/scheduling/v1alpha2/types.go @@ -201,7 +201,6 @@ type PodGroupTemplate struct { // +k8s:ifDisabled("WorkloadAwarePreemption")=+k8s:forbidden // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority - // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648 Priority *int32 `json:"priority,omitempty" protobuf:"varint,7,opt,name=priority"` } @@ -456,7 +455,6 @@ type PodGroupSpec struct { // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:optional // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:immutable // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:maximum=1000000000 # HighestUserDefinablePriority - // +k8s:ifEnabled("WorkloadAwarePreemption")=+k8s:minimum=-2147483648 Priority *int32 `json:"priority,omitempty" protobuf:"varint,7,opt,name=priority"` }