Merge pull request #133782 from aojea/lockDisableAllocatorDualWrite

lock DisableAllocatorDualWrite
This commit is contained in:
Kubernetes Prow Robot 2025-09-01 22:43:40 -07:00 committed by GitHub
commit cb163eb55b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 5 deletions

View file

@ -1231,7 +1231,8 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
DisableAllocatorDualWrite: {
{Version: version.MustParse("1.31"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Beta},
{Version: version.MustParse("1.34"), Default: true, PreRelease: featuregate.GA}, // remove after MultiCIDRServiceAllocator is GA
{Version: version.MustParse("1.34"), Default: true, PreRelease: featuregate.GA},
{Version: version.MustParse("1.35"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove after MultiCIDRServiceAllocator is GA
},
DisableCPUQuotaWithExclusiveCPUs: {

View file

@ -413,6 +413,10 @@
lockToDefault: false
preRelease: GA
version: "1.34"
- default: true
lockToDefault: true
preRelease: GA
version: "1.35"
- name: DisableCPUQuotaWithExclusiveCPUs
versionedSpecs:
- default: true

View file

@ -56,7 +56,7 @@ func TestCreateServiceSingleStackIPv4(t *testing.T) {
"--disable-admission-plugins=ServiceAccount",
fmt.Sprintf("--feature-gates=%s=%v,%s=%v", features.MultiCIDRServiceAllocator, enableMultiServiceCIDR, features.DisableAllocatorDualWrite, disableAllocatorDualWrite),
}
if !enableMultiServiceCIDR {
if !enableMultiServiceCIDR || !disableAllocatorDualWrite {
flags = append(flags, "--emulated-version=1.33")
}
s := kubeapiservertesting.StartTestServerOrDie(t,
@ -303,7 +303,7 @@ func TestCreateServiceSingleStackIPv6(t *testing.T) {
"--disable-admission-plugins=ServiceAccount",
fmt.Sprintf("--feature-gates=%s=%v,%s=%v", features.MultiCIDRServiceAllocator, enableMultiServiceCIDR, features.DisableAllocatorDualWrite, disableAllocatorDualWrite),
}
if !enableMultiServiceCIDR {
if !enableMultiServiceCIDR || !disableAllocatorDualWrite {
flags = append(flags, "--emulated-version=1.33")
}
s := kubeapiservertesting.StartTestServerOrDie(t,
@ -537,7 +537,7 @@ func TestCreateServiceDualStackIPv4IPv6(t *testing.T) {
"--disable-admission-plugins=ServiceAccount",
fmt.Sprintf("--feature-gates=%s=%v,%s=%v", features.MultiCIDRServiceAllocator, enableMultiServiceCIDR, features.DisableAllocatorDualWrite, disableAllocatorDualWrite),
}
if !enableMultiServiceCIDR {
if !enableMultiServiceCIDR || !disableAllocatorDualWrite {
flags = append(flags, "--emulated-version=1.33")
}
s := kubeapiservertesting.StartTestServerOrDie(t,
@ -819,7 +819,7 @@ func TestCreateServiceDualStackIPv6IPv4(t *testing.T) {
"--disable-admission-plugins=ServiceAccount",
fmt.Sprintf("--feature-gates=%s=%v,%s=%v", features.MultiCIDRServiceAllocator, enableMultiServiceCIDR, features.DisableAllocatorDualWrite, disableAllocatorDualWrite),
}
if !enableMultiServiceCIDR {
if !enableMultiServiceCIDR || !disableAllocatorDualWrite {
flags = append(flags, "--emulated-version=1.33")
}
s := kubeapiservertesting.StartTestServerOrDie(t,