upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-05-28 04:04:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Correct the usage of vlog's .Error() or .V().Info() methods

Browse source
This commit is contained in:
Tanner 2026-01-05 20:09:04 -05:00
parent b2ac9e206f
commit bb8b4b0d80
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/controller/storageversionmigrator/storageversionmigrator.go
View file

@ -224,7 +224,7 @@ func (svmc *SVMController) sync(ctx context.Context, key string) error {
return err
}
if !exists {
logger.V(4).Error(err, "resource does not exist in our rest mapper", "gvr", gvr.String())
logger.V(4).Info("resource does not exist in our rest mapper", "gvr", gvr.String())
if toBeProcessedSVM.CreationTimestamp.Add(time.Minute).After(time.Now()) {
return fmt.Errorf("resource does not exist in rest mapper, requeuing to attempt again: %w", err)
}
@ -241,7 +241,7 @@ func (svmc *SVMController) sync(ctx context.Context, key string) error {
return errMonitor
}
if !hasSynced {
logger.V(4).Error(errMonitor, "resource does not exist in GC", "gvr", gvr.String())
logger.V(4).Info("resource does not exist in GC", "gvr", gvr.String())
// our mapper could be missing a recently created custom resource, so give it some time to catch up
// we resync discovery every 30 seconds so twice that should be sufficient
@ -308,7 +308,7 @@ func (svmc *SVMController) runMigration(ctx context.Context, logger klog.Logger,
}
rvCmp, err := resourceversion.CompareResourceVersion(accessor.GetResourceVersion(), listResourceVersion)
if err != nil {
logger.V(4).Error(err, "Unable to compare the resource version of the resource", "namespace", accessor.GetNamespace(), "name", accessor.GetName(), "gvr", gvr.String(), "accessorRV", accessor.GetResourceVersion(), "listResourceVersion", listResourceVersion, "error", err.Error())
logger.Error(err, "Unable to compare the resource version of the resource", "namespace", accessor.GetNamespace(), "name", accessor.GetName(), "gvr", gvr.String(), "accessorRV", accessor.GetResourceVersion(), "listResourceVersion", listResourceVersion, "error", err.Error())
return svmc.failMigration(ctx, toBeProcessedSVM, err), true
}
if rvCmp == 1 {
@ -358,7 +358,7 @@ func (svmc *SVMController) runMigration(ctx context.Context, logger klog.Logger,
}
if errPatch != nil {
logger.V(4).Error(errPatch, "Failed to migrate the resource", "namespace", accessor.GetNamespace(), "name", accessor.GetName(), "gvr", gvr.String(), "reason", apierrors.ReasonForError(errPatch))
logger.Error(errPatch, "Failed to migrate the resource", "namespace", accessor.GetNamespace(), "name", accessor.GetName(), "gvr", gvr.String(), "reason", apierrors.ReasonForError(errPatch))
errStatus := svmc.failMigration(ctx, toBeProcessedSVM, errPatch)
return errStatus, true
}