upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-06-09 00:34:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #139524 from serathius/watchcache-benchmark-conflict

Browse source 
Reduce conflicts in benchmark between PATCH requests by making them sequential
This commit is contained in:
Kubernetes Prow Robot 2026-06-05 20:57:54 +05:30 committed by GitHub
commit b7de3e336d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
staging/src/k8s.io/apiserver/pkg/storage/testing/store_benchmarks.go
View file

@ -103,6 +103,7 @@ func runBenchmarkWriteThroughput(ctx context.Context, b *testing.B, store storag
var watchEvents atomic.Uint64
var listCalls atomic.Uint64
var listObjects atomic.Uint64
var index atomic.Uint64
switch loadType {
case loadNone:
@ -122,7 +123,8 @@ func runBenchmarkWriteThroughput(ctx context.Context, b *testing.B, store storag
b.ResetTimer()
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
writes.Add(runTraffic(ctx, b, store, data, trafficType))
i := int(index.Add(1)) % len(data.PodKeys)
writes.Add(runTraffic(ctx, b, store, data, trafficType, i))
}
})
elapsedSeconds := b.Elapsed().Seconds()
@ -159,41 +161,30 @@ func waitForConsistent(ctx context.Context, store storage.Interface) error {
return nil
}
func runTraffic(ctx context.Context, b *testing.B, store storage.Interface, data BenchmarkData, trafficType string) (writes uint64) {
func runTraffic(ctx context.Context, b *testing.B, store storage.Interface, data BenchmarkData, trafficType string, index int) (writes uint64) {
var podOut *example.Pod
switch trafficType {
case trafficDeleteCreate:
i := rand.Intn(len(data.PodKeys))
podOut = &example.Pod{}
err := store.Delete(ctx, data.PodKeys[i], podOut, nil, storage.ValidateAllObjectFunc, nil, storage.DeleteOptions{})
err := store.Delete(ctx, data.PodKeys[index], podOut, nil, storage.ValidateAllObjectFunc, nil, storage.DeleteOptions{})
if err == nil {
writes += 1
} else if !storage.IsNotFound(err) {
panic(fmt.Sprintf("Unexpected error on Delete %q: %v", data.PodKeys[i], err))
panic(fmt.Sprintf("Unexpected error on Delete %q: %v", data.PodKeys[index], err))
}
pod := data.Pods[i]
pod := data.Pods[index]
podOut = &example.Pod{}
err = store.Create(ctx, data.PodKeys[i], pod, podOut, 0)
err = store.Create(ctx, data.PodKeys[index], pod, podOut, 0)
if err == nil {
writes += 1
} else if !storage.IsExist(err) {
panic(fmt.Sprintf("Unexpected error on Create %q: %v", data.PodKeys[i], err))
panic(fmt.Sprintf("Unexpected error on Create %q: %v", data.PodKeys[index], err))
}
case trafficPatch:
i := rand.Intn(len(data.PodKeys))
podOut = &example.Pod{}
err := store.GuaranteedUpdate(ctx, data.PodKeys[i], podOut, false, nil, patchFunc(i), nil)
err := store.GuaranteedUpdate(ctx, data.PodKeys[index], podOut, false, nil, patchFunc(index), nil)
if err != nil {
panic(fmt.Sprintf("Unexpected error on Patch %q: %v", data.PodKeys[i], err))
} else {
writes += 1
}
// Execute patch second time to match 2 operations.
j := rand.Intn(len(data.PodKeys))
podOut = &example.Pod{}
err = store.GuaranteedUpdate(ctx, data.PodKeys[j], podOut, false, nil, patchFunc(j), nil)
if err != nil {
panic(fmt.Sprintf("Unexpected error on Patch %q: %v", data.PodKeys[j], err))
panic(fmt.Sprintf("Unexpected error on Patch %q: %v", data.PodKeys[index], err))
} else {
writes += 1
}