upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-05-28 04:04:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #134387 from adrianmoisey/attempt-at-fixing-flake

Browse source 
Use a dedicated delete channel in HPA test
This commit is contained in:
Kubernetes Prow Robot 2025-10-03 04:52:57 -07:00 committed by GitHub
commit aa42060beb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/controller/podautoscaler/horizontal_test.go
View file

@ -5192,6 +5192,7 @@ func TestMultipleHPAs(t *testing.T) {
const testNamespace = "dummy-namespace"
processed := make(chan string, hpaCount)
processedDeleted := make(chan string, 1)
testClient := &fake.Clientset{}
testScaleClient := &scalefake.FakeScaleClient{}
@ -5423,7 +5424,7 @@ func TestMultipleHPAs(t *testing.T) {
testClient.AddReactor("delete", "horizontalpodautoscalers", func(action core.Action) (handled bool, ret runtime.Object, err error) {
deleteAction := action.(core.DeleteAction)
hpaName := deleteAction.GetName()
processed <- hpaName
processedDeleted <- hpaName
return true, nil, nil
})
@ -5481,7 +5482,7 @@ func TestMultipleHPAs(t *testing.T) {
// Wait for deletion to be processed
select {
case deletedHPAName := <-processed:
case deletedHPAName := <-processedDeleted:
assert.Equal(t, hpaName, deletedHPAName, "Expected the deleted HPA name to match")
case <-time.After(5 * time.Second):
t.Fatalf("Timeout waiting for HPA deletion to be processed")