Move a comment about ginkgo to code that runs ginkgo

This commit is contained in:
Jan Safranek 2025-11-03 18:28:58 +01:00
parent 3e33e61968
commit a3bf2abddb

View file

@ -268,10 +268,6 @@ run_tests() {
export KUBE_CONTAINER_RUNTIME_NAME=containerd
export SNAPSHOTTER_VERSION="${SNAPSHOTTER_VERSION:-v8.4.0}"
echo "SNAPSHOTTER_VERSION is $SNAPSHOTTER_VERSION"
# ginkgo can take forever to exit, so we run it in the background and save the
# PID, bash will not run traps while waiting on a process, but it will while
# running a builtin like `wait`, saving the PID also allows us to forward the
# interrupt
# Enable VolumeGroupSnapshot tests in csi-driver-hostpath
export CSI_PROW_ENABLE_GROUP_SNAPSHOT=true
@ -290,6 +286,10 @@ sed "s|image: registry.k8s.io/sig-storage/snapshot-controller:.*|image: registry
kubectl apply -f - || exit 1
# ginkgo can take forever to exit, so we run it in the background and save the
# PID, bash will not run traps while waiting on a process, but it will while
# running a builtin like `wait`, saving the PID also allows us to forward the
# interrupt
./hack/ginkgo-e2e.sh \
'--provider=skeleton' "--num-nodes=${NUM_NODES}" \
"--ginkgo.focus=${FOCUS}" "--ginkgo.skip=${SKIP}" "--ginkgo.label-filter=${LABEL_FILTER}" \