upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-05-22 01:48:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

kube-proxy: don't do full periodic syncs on large cluster mode

Browse source 
Periodic full-syncs are just reconcile loops just in case somehow
the dataplane has drifted, however, they have an important cost on large
clusters.

We can avoid to perform full-sync if kube-proxy is in the "largecluster"
mode, we are already doing some optimization, so it is reasonable to
avoid the penalty of a full sync for a "just in case" operation.

Signed-off-by: Antonio Ojea <aojea@google.com>
This commit is contained in:
Antonio Ojea 2026-04-24 11:33:01 +00:00
parent d8d43a9034
commit 9daabbd6c7
No known key found for this signature in database
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/proxy/iptables/proxier.go
View file

@ -648,7 +648,9 @@ func (proxier *Proxier) syncProxyRules() (retryError error) {
// Keep track of how long syncs take.
start := time.Now()
doFullSync := proxier.needFullSync || (time.Since(proxier.lastFullSync) > proxyutil.FullSyncPeriod)
doFullSync := proxier.needFullSync ||
// Avoid regular full syncs for large clusters.
((time.Since(proxier.lastFullSync) > proxyutil.FullSyncPeriod) && !proxier.largeClusterMode)
defer func() {
metrics.SyncProxyRulesLatency.WithLabelValues(string(proxier.ipFamily)).Observe(metrics.SinceInSeconds(start))

15
pkg/proxy/iptables/proxier_test.go
View file

@ -5639,6 +5639,21 @@ func TestSyncProxyRulesLargeClusterMode(t *testing.T) {
t.Errorf("numComments (%d) != 0 after partial resync when numEndpoints (%d) > threshold (%d)", numComments, expectedEndpoints+3, largeClusterEndpointsThreshold)
}
// Even if FullSyncPeriod has elapsed, large-cluster mode should keep this as
// a partial resync when there are no explicit changes requiring a full sync.
if !fp.largeClusterMode {
t.Fatalf("expected to be in large cluster mode")
}
expectedLastFullSync := time.Now().Add(-proxyutil.FullSyncPeriod).Add(-time.Second)
fp.lastFullSync = expectedLastFullSync
err := fp.syncProxyRules()
if err != nil {
t.Fatalf("syncProxyRules failed: %v", err)
}
if !fp.lastFullSync.Equal(expectedLastFullSync) {
t.Fatalf("expected periodic sync in large cluster mode to skip full sync: lastFullSync changed from %v to %v", expectedLastFullSync, fp.lastFullSync)
}
// Now force a full resync and confirm that it rewrites the older services with
// no comments as well.
fp.forceSyncProxyRules()