From 1f59ea104a17c68b92653ec8cee57c7f93d41e59 Mon Sep 17 00:00:00 2001 From: Davanum Srinivas Date: Mon, 11 May 2026 08:21:05 -0400 Subject: [PATCH] Remove [Flaky] for green tests Drops f.WithFlaky() from two test blocks where the tag has become stale: - [sig-node] kubelet host cleanup with volume mounts [HostCleanup] (covers both NFS sub-tests: active and sleeping client pods) - [sig-storage] PersistentVolumes-local "should set different fsGroup for second pod if first pod is deleted" (covers all 8 volume-type variants from the parameterized parent) Testgrid evidence -- both dashboards show consistent passes across all 30 recent runs: https://testgrid.k8s.io/google-gce#gci-gce-flaky&include-filter-by-regex=Flaky https://testgrid.k8s.io/sig-testing-misc#gce-cos-master-flaky-repro&include-filter-by-regex=Flaky History: - HostCleanup was tagged [Flaky] in PR 41659 (merged 2017-04-13) as a quick workaround for parallel-execution interference with disruptive tests; the follow-up "remove [Flaky]" PR mentioned in that body never landed. Root-cause issue 31272 ("Hung volumes can wedge the kubelet") remains open. - fsGroup test was tagged [Flaky] in PR 75015 (merged 2019-03-06) to skip a race in DesiredStateOfWorld re-adding terminating-pod volumes. Root-cause issue 73168 ("Do not remount volume again after it is detached") remains open. The obsolete TODO comment referencing that issue is also removed. If either test regresses, the safe rollback is to restore f.WithFlaky() and reopen the conversation on issue 31272 / 73168. --- test/e2e/node/kubelet.go | 2 +- test/e2e/storage/persistent_volumes-local.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/test/e2e/node/kubelet.go b/test/e2e/node/kubelet.go index 0cebd5514e0..c06aa20bde9 100644 --- a/test/e2e/node/kubelet.go +++ b/test/e2e/node/kubelet.go @@ -369,7 +369,7 @@ var _ = SIGDescribe("kubelet", func() { }) // Test host cleanup when disrupting the volume environment. - f.Describe("host cleanup with volume mounts [HostCleanup]", f.WithFlaky(), func() { + f.Describe("host cleanup with volume mounts [HostCleanup]", func() { type hostCleanupTest struct { itDescr string diff --git a/test/e2e/storage/persistent_volumes-local.go b/test/e2e/storage/persistent_volumes-local.go index 4370defd348..0ec43fb0324 100644 --- a/test/e2e/storage/persistent_volumes-local.go +++ b/test/e2e/storage/persistent_volumes-local.go @@ -290,8 +290,7 @@ var _ = utils.SIGDescribe("PersistentVolumes-local", func() { e2epod.DeletePodOrFail(ctx, config.client, config.ns, pod2.Name) }) - f.It("should set different fsGroup for second pod if first pod is deleted", f.WithFlaky(), func(ctx context.Context) { - // TODO: Disabled temporarily, remove [Flaky] tag after #73168 is fixed. + f.It("should set different fsGroup for second pod if first pod is deleted", func(ctx context.Context) { fsGroup1, fsGroup2 := int64(1234), int64(4321) ginkgo.By("Create first pod and check fsGroup is set") pod1 := createPodWithFsGroupTest(ctx, config, testVol, fsGroup1, fsGroup1)