From 84fde398c4d9a91c808b419092e1711e8fcf2d81 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Sat, 17 Dec 2022 05:27:09 +0000 Subject: [PATCH] Ignore unstructured log warnings The fixes to this file included in 1.24 in 0f4d0660a7674f816d4f60791b1cfe191fab7050 rely on multi-line support in klog not present in the version used in 1.23 --- cmd/kube-scheduler/app/options/configfile.go | 1 + pkg/scheduler/internal/cache/debugger/dumper.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/cmd/kube-scheduler/app/options/configfile.go b/cmd/kube-scheduler/app/options/configfile.go index f1490dbccb1..befecf3162b 100644 --- a/cmd/kube-scheduler/app/options/configfile.go +++ b/cmd/kube-scheduler/app/options/configfile.go @@ -93,6 +93,7 @@ func LogOrWriteConfig(fileName string, cfg *config.KubeSchedulerConfiguration, c } if klog.V(2).Enabled() { + // nolint:logcheck // Ignore unstructured log lines in release branch klog.Info("Using component config", "\n-------------------------Configuration File Contents Start Here---------------------- \n", buf.String(), "\n------------------------------------Configuration File Contents End Here---------------------------------\n") } diff --git a/pkg/scheduler/internal/cache/debugger/dumper.go b/pkg/scheduler/internal/cache/debugger/dumper.go index 0d808c595e6..8e1fa6dbd49 100644 --- a/pkg/scheduler/internal/cache/debugger/dumper.go +++ b/pkg/scheduler/internal/cache/debugger/dumper.go @@ -46,6 +46,7 @@ func (d *CacheDumper) dumpNodes() { dump := d.cache.Dump() klog.InfoS("Dump of cached NodeInfo") for name, nodeInfo := range dump.Nodes { + // nolint:logcheck // Ignore unstructured log lines in release branch klog.Info(d.printNodeInfo(name, nodeInfo)) } } @@ -57,6 +58,7 @@ func (d *CacheDumper) dumpSchedulingQueue() { for _, p := range pendingPods { podData.WriteString(printPod(p)) } + // nolint:logcheck // Ignore unstructured log lines in release branch klog.Infof("Dump of scheduling queue:\n%s", podData.String()) }