upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-05-28 04:04:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

controller/ttl: Improve goroutine mgmt

Browse source 
Make sure all threads are terminated when Run returns.
This commit is contained in:
Ondra Kupka 2025-10-27 14:37:48 +01:00
parent 3ee8c53e53
commit 7240649e4f
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
pkg/controller/ttl/ttl_controller.go
View file

@ -122,19 +122,26 @@ var (
// Run begins watching and syncing.
func (ttlc *Controller) Run(ctx context.Context, workers int) {
defer utilruntime.HandleCrash()
defer ttlc.queue.ShutDown()
logger := klog.FromContext(ctx)
logger.Info("Starting TTL controller")
defer logger.Info("Shutting down TTL controller")
var wg sync.WaitGroup
defer func() {
logger.Info("Shutting down TTL controller")
ttlc.queue.ShutDown()
wg.Wait()
}()
if !cache.WaitForNamedCacheSyncWithContext(ctx, ttlc.hasSynced) {
return
}
for i := 0; i < workers; i++ {
go wait.UntilWithContext(ctx, ttlc.worker, time.Second)
wg.Go(func() {
wait.UntilWithContext(ctx, ttlc.worker, time.Second)
})
}
<-ctx.Done()
}