upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-02-20 00:11:21 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #123152 from tnqn/fix-error-log

Browse source 
Fix internal error when serializing groupLookupFailures in log
This commit is contained in:
Kubernetes Prow Robot 2024-10-23 01:17:29 +01:00 committed by GitHub
commit 6edbee19b9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/controller/garbagecollector/garbagecollector.go
View file

@ -782,7 +782,9 @@ func GetDeletableResources(logger klog.Logger, discoveryClient discovery.ServerR
preferredResources, lookupErr := discoveryClient.ServerPreferredResources()
if lookupErr != nil {
if groupLookupFailures, isLookupFailure := discovery.GroupDiscoveryFailedErrorGroups(lookupErr); isLookupFailure {
logger.Info("failed to discover some groups", "groups", groupLookupFailures)
// Serialize groupLookupFailures here as map[schema.GroupVersion]error is not json encodable, otherwise the
// logger would throw internal error.
logger.Info("failed to discover some groups", "groups", fmt.Sprintf("%q", groupLookupFailures))
} else {
logger.Info("failed to discover preferred resources", "error", lookupErr)
}