upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-06-09 00:34:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix testing utils

Browse source
This commit is contained in:
Lalit Chauhan 2026-04-29 17:31:39 +00:00
parent 89fb0b9b3e
commit 68ad19102c
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/api/testing/validation.go
View file

@ -424,12 +424,21 @@ func verifyValidationEquivalence(t *testing.T, expectedErrs field.ErrorList, run
testCtx := rest.WithAllDeclarativeEnforcedForTest(ctx)
allDeclarativeErrs := runValidations(testCtx)
// In this mode, strategy.go validation remove all hand written validations errors which are marked covered by DV.
// so we have to filter out errors which are filtered out by strategy.go.
// This is because DV will not return those errors due to short circuiting of validations at the parent node.
filteredExpectedErrors := make(field.ErrorList, 0, len(expectedErrs))
for _, err := range expectedErrs {
if !err.ShortCircuitedInDV {
filteredExpectedErrors = append(filteredExpectedErrors, err)
}
}
// The matcher here is more specific to ensure that errors from Alpha rules
// are included and matched correctly.
// This also ensure that errors are coming from the declarative validations only.
dvErrorMatcher := errOutputMatcher.ByValidationStabilityLevel().BySource()
if len(expectedErrs) > 0 {
dvErrorMatcher.Test(t, expectedErrs, allDeclarativeErrs)
if len(filteredExpectedErrors) > 0 {
dvErrorMatcher.Test(t, filteredExpectedErrors, allDeclarativeErrs)
} else if len(allDeclarativeErrs) != 0 {
t.Errorf("expected no errors, but got: %v", allDeclarativeErrs)
}