From 4f8757b4c0183a8087fcde074de1d065d512cbd5 Mon Sep 17 00:00:00 2001 From: Omer Aplatony Date: Fri, 10 Oct 2025 12:00:35 +0000 Subject: [PATCH] Remove flaky HPA deletion assertion in TestMultipleHPAs Signed-off-by: Omer Aplatony --- pkg/controller/podautoscaler/horizontal_test.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pkg/controller/podautoscaler/horizontal_test.go b/pkg/controller/podautoscaler/horizontal_test.go index 1aa8ff1a992..58b35b843f5 100644 --- a/pkg/controller/podautoscaler/horizontal_test.go +++ b/pkg/controller/podautoscaler/horizontal_test.go @@ -5192,7 +5192,6 @@ func TestMultipleHPAs(t *testing.T) { const testNamespace = "dummy-namespace" processed := make(chan string, hpaCount) - processedDeleted := make(chan string, 1) testClient := &fake.Clientset{} testScaleClient := &scalefake.FakeScaleClient{} @@ -5422,9 +5421,6 @@ func TestMultipleHPAs(t *testing.T) { }) testClient.AddReactor("delete", "horizontalpodautoscalers", func(action core.Action) (handled bool, ret runtime.Object, err error) { - deleteAction := action.(core.DeleteAction) - hpaName := deleteAction.GetName() - processedDeleted <- hpaName return true, nil, nil }) @@ -5480,14 +5476,6 @@ func TestMultipleHPAs(t *testing.T) { // Simulate the watch event for deletion hpaWatcher.Delete(&hpaList[0]) - // Wait for deletion to be processed - select { - case deletedHPAName := <-processedDeleted: - assert.Equal(t, hpaName, deletedHPAName, "Expected the deleted HPA name to match") - case <-time.After(5 * time.Second): - t.Fatalf("Timeout waiting for HPA deletion to be processed") - } - // Give the controller time to process the deletion and update the monitor assert.Eventually(t, func() bool { return hpaController.monitor.(*mockMonitor).GetObjectsCount() == hpaCount-1