upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-04-26 16:50:51 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #137461 from ahmedharabi/fix/statefulset-error-wrapping

Browse source 
statefulset: wrap errors with %w in StatefulPodControl
This commit is contained in:
Kubernetes Prow Robot 2026-03-07 00:08:25 +05:30 committed by GitHub
commit 2bbb175707
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/controller/statefulset/stateful_pod_control.go
View file

@ -260,7 +260,8 @@ func (spc *StatefulPodControl) ClaimsMatchRetentionPolicy(ctx context.Context, s
case apierrors.IsNotFound(err):
klog.FromContext(ctx).V(4).Info("Expected claim missing, continuing to pick up in next iteration", "PVC", klog.KObj(claim))
case err != nil:
return false, fmt.Errorf("Could not retrieve claim %s for %s when checking PVC deletion policy", claimName, pod.Name)
return false, fmt.Errorf(
"Could not retrieve claim %s for %s when checking PVC deletion policy: %w", claimName, pod.Name, err)
default:
if !isClaimOwnerUpToDate(logger, claim, set, pod) {
return false, nil
@ -385,13 +386,13 @@ func (spc *StatefulPodControl) createPersistentVolumeClaims(set *apps.StatefulSe
case apierrors.IsNotFound(err):
err := spc.objectMgr.CreateClaim(&claim, set)
if err != nil {
errs = append(errs, fmt.Errorf("failed to create PVC %s: %s", claim.Name, err))
errs = append(errs, fmt.Errorf("failed to create PVC %s: %w", claim.Name, err))
}
if err == nil || !apierrors.IsAlreadyExists(err) {
spc.recordClaimEvent("create", set, pod, &claim, err)
}
case err != nil:
errs = append(errs, fmt.Errorf("failed to retrieve PVC %s: %s", claim.Name, err))
errs = append(errs, fmt.Errorf("failed to retrieve PVC %s: %w", claim.Name, err))
spc.recordClaimEvent("create", set, pod, &claim, err)
default:
if pvc.DeletionTimestamp != nil {