upstream/kubernetes
1
0
Fork 0
mirror of https://github.com/kubernetes/kubernetes.git synced 2026-06-08 16:30:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update comments to explain why we delete on all errors in DaemonSet

Browse source
This commit is contained in:
Michael Aspinwall 2026-04-02 17:05:15 +00:00
parent 9a6c7a68f3
commit 1d78c7f2b1
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/controller/daemon/daemon_controller.go
View file

@ -1120,6 +1120,9 @@ func (dsc *DaemonSetsController) syncNodes(ctx context.Context, ds *apps.DaemonS
go func(ix int) {
defer deleteWait.Done()
if err := dsc.podControl.DeletePod(ctx, ds.Namespace, podsToDelete[ix], ds); err != nil {
// We are cleaning up an expectation that this delete will be observed,
// since any failure to delete the pod means that we will never observe
// the delete.
dsc.expectations.DeletionObserved(logger, dsKey)
if !apierrors.IsNotFound(err) {
logger.V(2).Info("Failed deletion, decremented expectations for daemon set", "daemonset", klog.KObj(ds))