From 07959fd168075cc24086dd4989bb07ed24db0ca7 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Tue, 9 Sep 2025 15:50:08 -0400 Subject: [PATCH] Remove redundant test of "empty EndpointSlice for Service with no Pods" This was being checked by two different conformance tests. --- test/e2e/network/endpointslice.go | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/test/e2e/network/endpointslice.go b/test/e2e/network/endpointslice.go index a81aacb9c4b..e455aec4444 100644 --- a/test/e2e/network/endpointslice.go +++ b/test/e2e/network/endpointslice.go @@ -202,7 +202,6 @@ var _ = common.SIGDescribe("EndpointSlice", func() { framework.ConformanceIt("should create Endpoints and EndpointSlices for Pods matching a Service", func(ctx context.Context) { labelPod1 := "pod1" labelPod2 := "pod2" - labelPod3 := "pod3" labelShared12 := "shared12" labelValue := "on" @@ -289,24 +288,6 @@ var _ = common.SIGDescribe("EndpointSlice", func() { svc2, err = cs.CoreV1().Services(f.Namespace.Name).Create(ctx, svc2, metav1.CreateOptions{}) framework.ExpectNoError(err, "error creating Service") - svc3 := &v1.Service{ - ObjectMeta: metav1.ObjectMeta{ - Name: "example-no-match", - }, - Spec: v1.ServiceSpec{ - Selector: map[string]string{labelPod3: labelValue}, - PublishNotReadyAddresses: true, - Ports: []v1.ServicePort{{ - Name: "example-no-match", - Port: 80, - TargetPort: intstr.FromInt32(8080), - Protocol: v1.ProtocolTCP, - }}, - }, - } - svc3, err = cs.CoreV1().Services(f.Namespace.Name).Create(ctx, svc3, metav1.CreateOptions{}) - framework.ExpectNoError(err, "error creating Service") - err = wait.PollUntilContextTimeout(ctx, 2*time.Second, 3*time.Minute, true, func(ctx context.Context) (bool, error) { var err error pod1, err = podClient.Get(ctx, pod1.Name, metav1.GetOptions{}) @@ -335,9 +316,6 @@ var _ = common.SIGDescribe("EndpointSlice", func() { ginkgo.By("referencing matching pods with named port") expectEndpointsAndSlices(ctx, cs, f.Namespace.Name, svc2, []*v1.Pod{pod1, pod2}, 2, 2, true) - ginkgo.By("creating empty Endpoints and EndpointSlices for no matching Pods") - expectEndpointsAndSlices(ctx, cs, f.Namespace.Name, svc3, []*v1.Pod{}, 0, 1, false) - // TODO: Update test to cover Endpoints recreation after deletes once it // actually works. ginkgo.By("recreating EndpointSlices after they've been deleted")