From 67ef0ca456450c67664449f8710574de501c212b Mon Sep 17 00:00:00 2001 From: "tao.yang" Date: Mon, 4 Sep 2023 16:59:23 +0800 Subject: [PATCH] cleanup: omit comparison with bool constants Signed-off-by: tao.yang Kubernetes-commit: b35357b6c08f21ba0fd312536051394c2567ec79 --- pkg/generate/generate_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/generate/generate_test.go b/pkg/generate/generate_test.go index 3037eb6f5..f4d181499 100644 --- a/pkg/generate/generate_test.go +++ b/pkg/generate/generate_test.go @@ -254,10 +254,10 @@ func TestGetBool(t *testing.T) { for _, tt := range testCases { t.Run(tt.name, func(t *testing.T) { got, err := GetBool(tt.parameters, tt.key, tt.defaultValue) - if err != nil && tt.expectError == false { + if err != nil && !tt.expectError { t.Errorf("%s: unexpected error: %v", tt.name, err) } - if err == nil && tt.expectError == true { + if err == nil && tt.expectError { t.Errorf("%s: expect error, got nil", tt.name) } if got != tt.expected {