From cdadfc287ac1b34e04c24bb21e1187c1c09c2c4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Va=C5=A1ek?= Date: Wed, 1 Apr 2026 10:59:36 +0200 Subject: [PATCH] turn off logging fixup! kaspdb: trash/garbage collector function for regular waste management of the "trash bin" --- src/knot/dnssec/kasp/kasp_db.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/knot/dnssec/kasp/kasp_db.c b/src/knot/dnssec/kasp/kasp_db.c index 4562954df..7d3b66ab4 100644 --- a/src/knot/dnssec/kasp/kasp_db.c +++ b/src/knot/dnssec/kasp/kasp_db.c @@ -606,7 +606,9 @@ int kasp_db_delete_trash(knot_lmdb_db_t *db, const knot_dname_t *zone_name, char continue; } - ret = kdnssec_delete_from_keystores(keystores, id, dname, true); + // For background garbage collection, log errors as debug. + ret = kdnssec_delete_from_keystores(keystores, id, dname, true, + for_delete != NULL ? true : false); ret = (ret == KNOT_ENOENT) ? KNOT_EOK : ret; if (ret != KNOT_EOK) { // Note: it isn't sure that there still is a key to delete. @@ -624,7 +626,8 @@ int kasp_db_delete_trash(knot_lmdb_db_t *db, const knot_dname_t *zone_name, char knot_lmdb_del_cur(&txn); } free(prefix.mv_data); - ret = (failed) ? KNOT_ERROR : ret; + // For background garbage collection, suppress trivial 'failed' errors. + ret = (for_delete != NULL) ? ret : ((failed && ret == KNOT_EOK) ? KNOT_ERROR : ret); } knot_lmdb_commit(&txn);