From d9f026057de04ea98986a581cfe38e4b7c3eabf2 Mon Sep 17 00:00:00 2001 From: Amr Elnaggar Date: Mon, 18 May 2026 04:19:38 +0300 Subject: [PATCH] add assertRealmsSorted to admin ui test functions --- js/apps/admin-ui/test/masthead/realm.spec.ts | 10 +++------- js/apps/admin-ui/test/masthead/realm.ts | 10 ++++++++++ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/js/apps/admin-ui/test/masthead/realm.spec.ts b/js/apps/admin-ui/test/masthead/realm.spec.ts index 5656849c6b2..9352dd60b1c 100644 --- a/js/apps/admin-ui/test/masthead/realm.spec.ts +++ b/js/apps/admin-ui/test/masthead/realm.spec.ts @@ -1,4 +1,4 @@ -import { test, expect } from "@playwright/test"; +import { test } from "@playwright/test"; import { v4 as uuid } from "uuid"; import adminClient from "../utils/AdminClient.ts"; import { DEFAULT_REALM } from "../utils/constants.ts"; @@ -21,6 +21,7 @@ import { goToRealmSection, getTextArea, assertTextAreaContains, + assertRealmsSorted, } from "./realm.ts"; const testRealmName = `Test-realm-${uuid()}`; @@ -123,12 +124,7 @@ test.describe.serial("Realm tests", () => { const realms = await page .locator(".pf-v5-c-table tr td:nth-child(2)") .allInnerTexts(); - expect( - realms.every((value, index, realms) => { - if (index === 0) return true; - return realms[index - 1] <= value; - }), - ).toBeTruthy(); + assertRealmsSorted(realms, 3); }); test("should disable preview if json very long", async ({ page }) => { diff --git a/js/apps/admin-ui/test/masthead/realm.ts b/js/apps/admin-ui/test/masthead/realm.ts index 1c60748251e..0c99f326307 100644 --- a/js/apps/admin-ui/test/masthead/realm.ts +++ b/js/apps/admin-ui/test/masthead/realm.ts @@ -50,3 +50,13 @@ export function getTextArea(page: Page) { export async function assertTextAreaContains(page: Page, content: string) { await expect(getTextArea(page)).toContainText(content); } + +export function assertRealmsSorted(realms: string[], length: number) { + expect(realms.length).toBeGreaterThanOrEqual(length); + expect( + realms.every((value, index, realms) => { + if (index === 0) return true; + return realms[index - 1] <= value; + }), + ).toBeTruthy(); +}