From 99866bfdbea99667ff7cf5bf27dfbbbb7efd5d05 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Mon, 17 Oct 2016 13:51:58 +0200 Subject: [PATCH] IniWriterTest: make recently added tests more expressive refs #11743 --- .../library/Icinga/File/Ini/IniWriterTest.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/php/library/Icinga/File/Ini/IniWriterTest.php b/test/php/library/Icinga/File/Ini/IniWriterTest.php index e4bfd2716..9e38aa9bd 100644 --- a/test/php/library/Icinga/File/Ini/IniWriterTest.php +++ b/test/php/library/Icinga/File/Ini/IniWriterTest.php @@ -409,9 +409,9 @@ EOD; $config->setSection('garbage', $section); $iniWriter = new IniWriter($config, '/dev/null'); - $this->assertEquals( - 0, - preg_match('/foobar/', $iniWriter->render()), + $this->assertNotContains( + 'foobar', + $iniWriter->render(), 'IniWriter persists section keys with null values' ); } @@ -424,9 +424,9 @@ EOD; $config->setSection('garbage', $section); $iniWriter = new IniWriter($config, '/dev/null'); - $this->assertEquals( - 1, - preg_match('/foobar/', $iniWriter->render()), + $this->assertContains( + 'foobar', + $iniWriter->render(), 'IniWriter doesn\'t persist section keys with empty values' ); } @@ -441,9 +441,9 @@ EOD; $section = $config->getSection('garbage'); $section->foobar = null; $iniWriter = new IniWriter($config, $filename); - $this->assertEquals( - 0, - preg_match('/foobar/', $iniWriter->render()), + $this->assertNotContains( + 'foobar', + $iniWriter->render(), 'IniWriter doesn\'t remove section keys with null values' );