From 01b93024f6e27cc93d63c3afddde62b3ffaf49cc Mon Sep 17 00:00:00 2001 From: Sukhwinder Dhillon Date: Tue, 15 Aug 2023 15:37:08 +0200 Subject: [PATCH] CreateTicketLinks: Variable `$ticket` is always set, but can be emtpy --- application/views/helpers/CreateTicketLinks.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/application/views/helpers/CreateTicketLinks.php b/application/views/helpers/CreateTicketLinks.php index 4f8a27249..dda55a654 100644 --- a/application/views/helpers/CreateTicketLinks.php +++ b/application/views/helpers/CreateTicketLinks.php @@ -17,7 +17,7 @@ class Zend_View_Helper_CreateTicketLinks extends Zend_View_Helper_Abstract public function createTicketLinks($text) { $tickets = $this->view->tickets; - /** @var \Icinga\Application\Hook\TicketHook $tickets */ - return isset($tickets) ? $tickets->createLinks($text) : $text; + /** @var \Icinga\Application\Hook\TicketHook|array|null $tickets */ + return ! empty($tickets) ? $tickets->createLinks($text) : $text; } }