upstream/icingaweb2-module-director
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-director.git synced 2026-05-28 04:35:53 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
icingaweb2-module-director/library
History
Johannes Rauh 61f2586e7a
Remove dead FinishedProcessState catch handler 
`FinishedProcessState` does not implement `\Throwable`, so `catch(function
(FinishedProcessState $state))` can never trigger in react/promise v3 where
rejection reasons must be `\Throwable`.

This is safe to remove because `IcingaCli` already rejects with an `Exception`
wrapping the process state reason:

```php
$deferred->reject(new Exception($state->getReason()));
```

The existing `catch(\Exception $e)` handler already covers this.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:16 +02:00
..
Director Remove dead FinishedProcessState catch handler 2026-04-30 15:11:16 +02:00