From 5ad777a7cc267af11e0ffbeea25b9cf006bdf389 Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Mon, 10 Jul 2017 19:52:45 +0200
Subject: [PATCH] SelfServiceController: fix check for unset values

---
 application/controllers/SelfServiceController.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/application/controllers/SelfServiceController.php b/application/controllers/SelfServiceController.php
index e6389938..02544ace 100644
--- a/application/controllers/SelfServiceController.php
+++ b/application/controllers/SelfServiceController.php
@@ -276,7 +276,7 @@ class SelfServiceController extends ActionController
     {
         foreach ($keys as $key) {
             $value = $settings->get("self-service/$key");
-            if (strlen($key)) {
+            if (strlen($value)) {
                 $params[$key] = $value;
             }
         }
@@ -285,7 +285,10 @@ class SelfServiceController extends ActionController
     protected function addBooleanSettingsToParams(Settings $settings, array $keys, array & $params)
     {
         foreach ($keys as $key) {
-            $params[$key] = $settings->get("self-service/$key") === 'y';
+            $value = $settings->get("self-service/$key");
+            if ($value !== null) {
+                $params[$key] = $value === 'y';
+            }
         }
     }
 }