Commit graph

586 commits

Author SHA1 Message Date
Sukhwinder Dhillon
d0df785bbd BaseTestCase: Param $subDir can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
43b391880d LegacyConfigRenderer: Don't use dynamic property 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
7605d5e007 LegacyConfigParser: Property $prevKey can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6f81fed8e7 NodeTile: Fix incorrect phpDoc 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
26b0d921ea Renderer::renderStateBadges(): Return type can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
ab8fe2aca6 (ServiceDetail/DetailView)Extension: Property $storage can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
3544c21056 Node: Property $state can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6934016ef0 Node: var_export() param#2 expects bool 2023-08-24 13:29:04 +02:00
Sukhwinder Dhillon
ad3cb81dc9 NodeAction: json_decode() $param#2 expects bool 2023-08-24 13:28:55 +02:00
Sukhwinder Dhillon
f960d09cc2 BpNode: Remove unreachable break statements 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
541ec5da6c BpNode: Property $children can be null 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
598e9a1af0 BpConfig::getNode(): Define exact return types in PhpDoc
- This fixes the IDE's issue `Call to an undefined method`, which is caused by the fact that the parent class `Node` does not contain all the methods defined in the child classes.
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
ae8e71106f BpConfig::hasChanges(): Fix incorrect return type 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
6306b5306c Define variable type when method returns a class object
- This helps the IDE to find class methods and resolves the `call to an undefined method` issue
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
21933d1868 NodeAction::create(): Avoid unnecessary variable initialization 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
7346cd1cab HostServiceTermValidator:isValid(): Add missing return statement 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
35d151b70d Sort Trait: Make $sort nullable and adjust code accordingly
- Update phpDoc
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
92e982bf3d Remove unused class Form and FormStateOverrides 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
e638fade56 Renderer: Fix that !empty($elements) is always true 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
9e67b56bca RenderedProcessActionBar: Remove unused constructor param $auth 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
8923476277 BpNode::getMissingChildren(): Use child name if alias not given
Host/Service alias is optional and null as default
2023-08-10 12:45:17 +02:00
Johannes Meyer
b8d5f0de2b Drop unused trait EnumList 2023-08-09 16:13:01 +02:00
Johannes Meyer
30d952ae0a Drop obsolete form element class StateOverrides 2023-08-09 16:13:01 +02:00
Johannes Meyer
0ea04f898f Drop obsolete class NoDuplicateChildrenValidator 2023-08-09 16:13:01 +02:00
Johannes Meyer
d9c6debfa9 ServiceNode: Change alias to <service> on <host> 2023-08-09 16:13:01 +02:00
Johannes Meyer
9c84764157 BpNode: Re-index childnames upon node removal 2023-08-09 16:13:01 +02:00
Johannes Meyer
6dd8a51ce5 Introduce new form validator for host/service terms 2023-08-09 16:13:01 +02:00
Johannes Meyer
46cce05c0a Add ipl-form compatible implementation of the state override element 2023-08-09 16:13:01 +02:00
Johannes Meyer
0fdee96deb IDO: Add custom hoststatus and servicestatus queries
For autocompletion with custom variable support, it is
required to be able to filter for custom variable values
if no customvariable name is known. But since the template
how custom variables are joined is on a private property,
this many classes are required to circumvent/adjust that.
2023-08-09 16:13:01 +02:00
Sukhwinder Dhillon
2576fc3dc3 BpConfig: Don't add same error message multiple times 2023-08-09 15:56:34 +02:00
Sukhwinder Dhillon
25f37d6575 Use unescaped node name for missing children 2023-08-09 15:56:34 +02:00
Sukhwinder Dhillon
f93873623f Call it faulty config intead of invalid config 2023-08-09 15:56:34 +02:00
Sukhwinder Dhillon
08cae45336 Imported Node: Don't break view if source config file is faulty 2023-08-09 15:56:34 +02:00
Johannes Meyer
64eb2a7f68 BaseTestCase: Use Icinga Web's base test case 2023-08-09 14:29:41 +02:00
Johannes Meyer
1d08c954ba IcingaDbState: Fix postgres support
-.-
2023-08-09 14:10:37 +02:00
Johannes Meyer
ffab7edcb3 IcingaDbState: Apply state data from redis 2023-08-09 10:53:40 +02:00
Johannes Meyer
78ad4491d2 IcingaDbState: Optimize queries
There's no need to fetch more data than required.
And issuing count queries only for benchmarks.. -.-
Also bypasses ipl-orm to fetch results now.

fixes #343
2023-08-09 10:22:10 +02:00
Sukhwinder Dhillon
af4b98faeb Use fontawesome icons with ipl\Web\Widget\Icon class everywhere 2023-08-08 12:24:29 +02:00
Sukhwinder Dhillon
1360e1e4a0 Avoid inline css 2023-08-08 11:39:24 +02:00
Johannes Meyer
3fe17336dc Escape semicolons in node names
fixes #312
2023-08-08 08:46:48 +02:00
Johannes Meyer
52c150c56b Use the new Sort trait where applicable
Moves the entire order processing to the renderers as that's
where it's mostly relevant. The only cases where nodes are
still ordered outside the rendering is where changes are
applied based on user input, which happened based on what's
been previously rendered.
2023-08-03 15:19:28 +02:00
Johannes Meyer
c3d09fd601 Introduce Icinga\Module\Businessprocess\Common\Sort 2023-08-03 15:06:08 +02:00
Johannes Meyer
96f94f9959 Controller: Extend ipl\Web\Compat\CompatController 2023-08-03 15:06:08 +02:00
Johannes Meyer
926ac14bd9 css: Apply form specific rules only to form.bp-form 2023-08-03 15:06:08 +02:00
Johannes Meyer
1ac87cb4ea Let all config forms extend BpConfigBaseForm
They're all too similar.
2023-08-03 15:06:08 +02:00
raviks789
654ba0474d
Show Ack icon in tree view for nodes with both downtime and acknowledgement (#352)
Acknowledgement takes priority in handled nodes and hence it is
sufficient to show acknowledged icons in case the handled node has an
acknowledgement and also a downtime is scheduled for it.
2023-08-03 15:01:48 +02:00
raviks789
4a3b3e3657 Show Ack/Downtime icons in the node tiles for the handled nodes
In case the hosts/services are acknowleded or have scheduled downtime show Acknowledeged or
Downtime icons respectively.
2023-08-03 14:53:08 +02:00
Sukhwinder Dhillon
da0c72d578 DashboardAction: Use ipl-web's icon 2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
6b4a3cbc0c Do not break overview page if existing business-process has invalid config
- Add icon and config file name to broken `business-process`
- Use font-awesome icon
2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
1aba349be5 NodeRemoveAction: Remove stateoverrides of node while removing node 2023-08-01 11:14:18 +02:00