From f5d551bbf00e091e6cf447e75ddc677cb098b5c5 Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Thu, 16 Feb 2017 14:05:16 +0100
Subject: [PATCH] ImportedNode: improve link targets, fix rendering

refs #108
---
 library/Businessprocess/ImportedNode.php                 | 9 ++++-----
 .../Businessprocess/Renderer/TileRenderer/NodeTile.php   | 3 +++
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/library/Businessprocess/ImportedNode.php b/library/Businessprocess/ImportedNode.php
index 6634734..a94b43b 100644
--- a/library/Businessprocess/ImportedNode.php
+++ b/library/Businessprocess/ImportedNode.php
@@ -23,7 +23,7 @@ class ImportedNode extends Node
     protected $className = 'subtree';
 
     /** @var BpConfig */
-    protected $config;
+    private $config;
 
     /**
      * @inheritdoc
@@ -42,8 +42,6 @@ class ImportedNode extends Node
 
         if (isset($object->state)) {
             $this->setState($object->state);
-        } else {
-            $this->setMissing();
         }
     }
 
@@ -101,8 +99,9 @@ class ImportedNode extends Node
      */
     public function isMissing()
     {
-        // TODO: WHY? return $this->getState() === null;
-        return $this->importedNode()->isMissing();
+        $this->getState();
+        // Probably doesn't work, as we create a fake node with worse state
+        return $this->missing;
     }
 
     /**
diff --git a/library/Businessprocess/Renderer/TileRenderer/NodeTile.php b/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
index 8085e4a..96390f9 100644
--- a/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
+++ b/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
@@ -190,6 +190,9 @@ class NodeTile extends BaseElement
             );
         } else {
             $link = Link::create($node->getAlias(), $url);
+            if ($node instanceof ImportedNode) {
+                $link->attributes()->add('data-base-target', '_next');
+            }
         }
 
         return $link;