From f022c0f101664a7e1e20de5bc3d5ae3d1c895edb Mon Sep 17 00:00:00 2001 From: Johannes Meyer Date: Mon, 14 Jan 2019 15:54:05 +0100 Subject: [PATCH] NodeMoveAction: Properly handle unbound nodes --- library/Businessprocess/Modification/NodeMoveAction.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/library/Businessprocess/Modification/NodeMoveAction.php b/library/Businessprocess/Modification/NodeMoveAction.php index b2d8638..4b1735d 100644 --- a/library/Businessprocess/Modification/NodeMoveAction.php +++ b/library/Businessprocess/Modification/NodeMoveAction.php @@ -176,9 +176,9 @@ class NodeMoveAction extends NodeAction $config->addRootNode($name); $i = 0; - foreach ($newNodes as $_ => $newNode) { + foreach ($newNodes as $newName => $newNode) { /** @var BpNode $newNode */ - if ($newNode->getDisplay() > 0) { + if ($newNode->getDisplay() > 0 || $newName === $name) { $i += 1; if ($newNode->getDisplay() !== $i) { $newNode->setDisplay($i); @@ -193,6 +193,7 @@ class NodeMoveAction extends NodeAction } else { if ($this->newParent !== null) { $config->removeRootNode($name); + $node->setDisplay(0); } $i = 0;