From e638fade56a22928c59705f8f5c743aa4135662c Mon Sep 17 00:00:00 2001 From: Sukhwinder Dhillon Date: Wed, 12 Jul 2023 10:08:08 +0200 Subject: [PATCH] Renderer: Fix that `!empty($elements)` is always true --- library/Businessprocess/Renderer/Renderer.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/library/Businessprocess/Renderer/Renderer.php b/library/Businessprocess/Renderer/Renderer.php index 6e68da4..9917ed6 100644 --- a/library/Businessprocess/Renderer/Renderer.php +++ b/library/Businessprocess/Renderer/Renderer.php @@ -169,8 +169,6 @@ abstract class Renderer extends HtmlDocument */ public function renderStateBadges($summary, $totalChildren) { - $elements = []; - $itemCount = Html::tag( 'span', [ @@ -181,7 +179,7 @@ abstract class Renderer extends HtmlDocument sprintf(mtp('businessprocess', '%u Child', '%u Children', $totalChildren), $totalChildren) ); - $elements[] = array_filter([ + $elements = array_filter([ $this->createBadgeGroup($summary, 'CRITICAL'), $this->createBadgeGroup($summary, 'UNKNOWN'), $this->createBadgeGroup($summary, 'WARNING'),