upstream/icingaweb2-module-businessprocess
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-businessprocess.git synced 2026-02-02 16:39:25 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: Switching to the icingadb backend and searching host/service node in add/edit form throws an error (#443)

Browse source 
`HostServiceTermValidator`: `$testConfig` requires backend for
`MonitoringState::apply()` call.

If the `$testConfig` has no backend set and icingadb is in use,
`MonitoringState::__construct($config) => $config->getBackend()` returns
an icingadb backend that is not suitable for the `MonitoringState`
class.

fixes
https://github.com/Icinga/icingaweb2-module-businessprocess/issues/430
This commit is contained in:
Johannes Meyer 2024-04-19 10:20:53 +02:00 committed by GitHub
commit c4ca750eb1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
library/Businessprocess/Web/Form/Validator/HostServiceTermValidator.php
View file

@ -45,7 +45,8 @@ class HostServiceTermValidator extends BaseValidator
}
$isValid = true;
$testConfig = new BpConfig();
$testConfig = (new BpConfig())
->setBackend($this->parent->getBpConfig()->getBackend());
foreach ($terms as $term) {
/** @var Term $term */
@ -68,7 +69,7 @@ class HostServiceTermValidator extends BaseValidator
}
}
if ($this->parent->getBpConfig()->getBackend() instanceof MonitoringBackend) {
if ($testConfig->getBackend() instanceof MonitoringBackend) {
MonitoringState::apply($testConfig);
} else {
IcingaDbState::apply($testConfig);

10
phpstan-baseline-standard.neon
View file

@ -4345,16 +4345,6 @@ parameters:
count: 1
path: library/Businessprocess/Web/Form/QuickForm.php
-
message: "#^Call to an undefined method Icinga\\\\Module\\\\Businessprocess\\\\BpNode\\|Icinga\\\\Module\\\\Businessprocess\\\\MonitoredNode\\:\\:addChild\\(\\)\\.$#"
count: 1
path: library/Businessprocess/Web/Form/Validator/HostServiceTermValidator.php
-
message: "#^Parameter \\#1 \\$label of method ipl\\\\Web\\\\FormElement\\\\TermInput\\\\Term\\:\\:setLabel\\(\\) expects string, string\\|null given\\.$#"
count: 1
path: library/Businessprocess/Web/Form/Validator/HostServiceTermValidator.php
-
message: "#^Method Icinga\\\\Module\\\\Businessprocess\\\\Web\\\\Navigation\\\\Renderer\\\\ProcessProblemsBadge\\:\\:getBpConfigName\\(\\) has no return type specified\\.$#"
count: 1