From 93a2589909ebba43510620e7aae9934ed6a1f9ca Mon Sep 17 00:00:00 2001 From: Johannes Meyer Date: Tue, 15 Jan 2019 09:50:14 +0100 Subject: [PATCH] NodeMoveAction: Interpret `$from` as index and not as display value --- library/Businessprocess/Modification/NodeMoveAction.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/library/Businessprocess/Modification/NodeMoveAction.php b/library/Businessprocess/Modification/NodeMoveAction.php index 4b1735d..5754717 100644 --- a/library/Businessprocess/Modification/NodeMoveAction.php +++ b/library/Businessprocess/Modification/NodeMoveAction.php @@ -90,12 +90,13 @@ class NodeMoveAction extends NodeAction $this->error('Node "%s" not found at position %d', $name, $this->from); } } else { - if (! $config->hasNode($name)) { + if (! $config->hasRootNode($name)) { $this->error('Toplevel process "%s" not found', $name); } - if ($config->getBpNode($name)->getDisplay() !== $this->from + 1) { - $this->error('Toplevel process "%s" not found at position %d', $name, $this->from + 1); + $nodes = $config->listRootNodes(); + if (! isset($nodes[$this->from]) || $nodes[$this->from] !== $name) { + $this->error('Toplevel process "%s" not found at position %d', $name, $this->from); } }