From 72fc8b03c93a384a044593c57774b69ddc16e50e Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Fri, 17 Feb 2017 18:49:17 +0100
Subject: [PATCH] Metadata: allowed roles are a simple array

refs #98
---
 library/Businessprocess/Metadata.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/library/Businessprocess/Metadata.php b/library/Businessprocess/Metadata.php
index 5af5050..7b32ffd 100644
--- a/library/Businessprocess/Metadata.php
+++ b/library/Businessprocess/Metadata.php
@@ -240,12 +240,10 @@ class Metadata
 
     public function hasOneOfTheAllowedRoles(User $user)
     {
-        foreach ($this->listAllowedRoles() as $roles) {
-            foreach ($roles as $roleName) {
-                foreach ($user->getRoles() as $role) {
-                    if ($role->getName() === $roleName) {
-                        return true;
-                    }
+        foreach ($this->listAllowedRoles() as $roleName) {
+            foreach ($user->getRoles() as $role) {
+                if ($role->getName() === $roleName) {
+                    return true;
                 }
             }
         }