From 51c7fdf6c972b9a0a45764a0c6aed93d9d743031 Mon Sep 17 00:00:00 2001
From: Ravi Kumar Kempapura Srinivasa <ravi.srinivasa@icinga.com>
Date: Wed, 26 Feb 2020 17:43:28 +0100
Subject: [PATCH] Fix 'Trying to access a missing business process node
 <$name>'

If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.
---
 .../Renderer/TileRenderer/NodeTile.php        | 58 +++++++++++--------
 1 file changed, 35 insertions(+), 23 deletions(-)

diff --git a/library/Businessprocess/Renderer/TileRenderer/NodeTile.php b/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
index e4f378f..d359d1d 100644
--- a/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
+++ b/library/Businessprocess/Renderer/TileRenderer/NodeTile.php
@@ -85,20 +85,30 @@ class NodeTile extends BaseHtmlElement
                 $this->addActionLinks();
             }
         }
+        if (! $node instanceof ImportedNode || ! $node->isMissing()) {
+            $link = $this->getMainNodeLink();
+            if ($renderer->isBreadcrumb()) {
+                $link->prepend((new StateBall(strtolower($node->getStateName())))->addAttributes([
+                    'title' => sprintf(
+                        '%s %s',
+                        $node->getStateName(),
+                        DateFormatter::timeSince($node->getLastStateChange())
+                    )
+                ]));
+            }
 
-        $link = $this->getMainNodeLink();
-        if ($renderer->isBreadcrumb()) {
-            $link->prepend((new StateBall(strtolower($node->getStateName())))->addAttributes([
-                'title' => sprintf(
-                    '%s %s',
-                    $node->getStateName(),
-                    DateFormatter::timeSince($node->getLastStateChange())
+            $this->add($link);
+        } else {
+            $this->add(Html::tag(
+                'a',
+                Html::tag(
+                    'span',
+                    ['style' => 'font-size: 75%'],
+                    sprintf('Trying to access a missing business process node "%s"', $node->getNodeName())
                 )
-            ]));
+            ));
         }
 
-        $this->add($link);
-
         if ($node instanceof BpNode && !$renderer->isBreadcrumb()) {
             $this->add(Html::tag(
                 'p',
@@ -191,19 +201,21 @@ class NodeTile extends BaseHtmlElement
                 ],
                 Html::tag('i', ['class' => 'icon icon-sitemap'])
             ));
-            if ($node->getBpConfig()->getName() !== $this->renderer->getBusinessProcess()->getName()) {
-                $this->actions()->add(Html::tag(
-                    'a',
-                    [
-                        'data-base-target'  => '_next',
-                        'href'              => $this->renderer->getSourceUrl($node)->getAbsoluteUrl(),
-                        'title'             => mt(
-                            'businessprocess',
-                            'Show this process as part of its original configuration'
-                        )
-                    ],
-                    Html::tag('i', ['class' => 'icon icon-forward'])
-                ));
+            if ($node instanceof ImportedNode) {
+                if (! $node->isMissing()) {
+                    $this->actions()->add(Html::tag(
+                        'a',
+                        [
+                            'data-base-target'  => '_next',
+                            'href'              => $this->renderer->getSourceUrl($node)->getAbsoluteUrl(),
+                            'title'             => mt(
+                                'businessprocess',
+                                'Show this process as part of its original configuration'
+                            )
+                        ],
+                        Html::tag('i', ['class' => 'icon icon-forward'])
+                    ));
+                }
             }
 
             $url = $node->getInfoUrl();