upstream/icingaweb2-module-businessprocess
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-businessprocess.git synced 2026-01-06 05:29:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

LegacyStorageTest: improve readability...

Browse source 
...and move config "loading" to BaseTestCase
This commit is contained in:
Thomas Gelf 2016-11-23 23:03:48 +01:00
parent d6f1d86ea4
commit 12a9459eaf
2 changed files with 24 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
library/Businessprocess/Test/BaseTestCase.php
View file

@ -2,6 +2,7 @@
namespace Icinga\Module\Businessprocess\Test;
use Icinga\Application\Config;
use Icinga\Application\ApplicationBootstrap;
use Icinga\Application\Icinga;
use PHPUnit_Framework_TestCase;
@ -19,6 +20,11 @@ abstract class BaseTestCase extends PHPUnit_Framework_TestCase
$this->app();
}
protected function emptyConfigSection()
{
return Config::module('businessprocess')->getSection('global');
}
/**
* @param null $subDir
* @return string

34
test/php/library/Businessprocess/Storage/LegacyStorageTest.php
View file

@ -2,23 +2,21 @@
namespace Tests\Icinga\Module\Businessprocess\Storage;
use Icinga\Application\Config;
use Icinga\Module\Businessprocess\Test\BaseTestCase;
use Icinga\Module\Businessprocess\Storage\LegacyStorage;
use Icinga\Module\Businessprocess\Storage\Storage;
class LegacyStorageTest extends BaseTestCase
{
public function testWhetherItCanBeInstantiatedWithAnEmptyConfigSection()
public function testCanBeInstantiatedWithAnEmptyConfigSection()
{
$baseClass = 'Icinga\\Module\\Businessprocess\\Storage\\LegacyStorage';
$this->assertInstanceOf(
$baseClass,
new LegacyStorage(Config::module('businessprocess')->getSection('global'))
new LegacyStorage($this->emptyConfigSection())
);
}
public function testWhetherDefaultConfigDirIsDetermined()
public function testDefaultConfigDirIsDiscoveredCorrectly()
{
$this->assertEquals(
$this->getTestsBaseDir('config/modules/businessprocess/processes'),
@ -26,7 +24,7 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherAllProcessesAreListed()
public function testAllAvailableProcessesAreListed()
{
$keys = array_keys($this->makeInstance()->listProcesses());
sort($keys);
@ -40,7 +38,7 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherHeadersAreRespectedInProcessList()
public function testHeaderTitlesAreRespectedInProcessList()
{
$keys = array_values($this->makeInstance()->listProcesses());
sort($keys);
@ -54,7 +52,7 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherProcessFilenameIsReturned()
public function testProcessFilenameIsReturned()
{
$this->assertEquals(
$this->getTestsBaseDir('config/modules/businessprocess/processes/simple_with-header.conf'),
@ -62,21 +60,21 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherExistingProcessExists()
public function testAnExistingProcessExists()
{
$this->assertTrue(
$this->makeInstance()->hasProcess('simple_with-header')
);
}
public function testWhetherMissingProcessIsMissing()
public function testAMissingProcessIsMissing()
{
$this->assertFalse(
$this->makeInstance()->hasProcess('simple_with-headerx')
);
}
public function testWhetherValidProcessCanBeLoaded()
public function testAValidProcessCanBeLoaded()
{
$processClass = 'Icinga\\Module\\Businessprocess\\BusinessProcess';
$this->assertInstanceOf(
@ -85,7 +83,7 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherConfigCanBeLoadedFromAString()
public function testProcessConfigCanBeLoadedFromAString()
{
$processClass = 'Icinga\\Module\\Businessprocess\\BusinessProcess';
$this->assertInstanceOf(
@ -94,10 +92,14 @@ class LegacyStorageTest extends BaseTestCase
);
}
public function testWhetherProcessSourceCanBeFetched()
public function testFullProcessSourceCanBeFetched()
{
$this->assertEquals(
file_get_contents($this->getTestsBaseDir('config/modules/businessprocess/processes/simple_with-header.conf')),
file_get_contents(
$this->getTestsBaseDir(
'config/modules/businessprocess/processes/simple_with-header.conf'
)
),
$this->makeInstance()->getSource('simple_with-header')
);
}
@ -107,6 +109,6 @@ class LegacyStorageTest extends BaseTestCase
*/
protected function makeInstance()
{
return new LegacyStorage(Config::module('businessprocess')->getSection('global'));
return new LegacyStorage($this->emptyConfigSection());
}
}
}