Commit graph

1972 commits

Author SHA1 Message Date
Julian Brost
be9054628a Ensure extra config options are properly initialized
YAML is decoded by the structure of the YAML source document, not the Go
destination data structure. Therefore, the old code did not always call
UnmarshalYAML() on all sub-structs. Therefore, defaults were not always set but
zero values were used, resulting in all kind of strange behavior.

This commit changes the code so that it no longer relies on individual
UnmarshalYAML() functions to set the defaults for each sub-struct but instead
just sets all of them when creating the surrounding Config instance. It also
moves the config validation to separate Validate() functions.
2021-09-01 18:49:38 +02:00
Alexander A. Klimov
3f8703310c Clarify what MustPackAny() does
It always packs a slice, even if only one item given.
2021-08-20 11:54:00 +02:00
Noah Hilverling
b9ec99185a Schema: Add description to downtime columns 'triggered_by_id' and 'parent_id' 2021-08-12 14:41:15 +02:00
Alexander Aleksandrovič Klimov
a3875d82d2
Merge pull request #337 from Icinga/bugfix/icingadb-help-should-not-display-a-stack-trace-at-the-end-334
Don't print stack on CLI parsing failure or --help
2021-08-11 11:08:07 +02:00
Eric Lippmann
3aa448b909
Merge pull request #342 from Icinga/dependabot/go_modules/github.com/go-redis/redis/v8-8.11.2
Bump github.com/go-redis/redis/v8 from 8.11.1 to 8.11.2
2021-08-10 13:29:24 +02:00
Alexander A. Klimov
3d0c56fe2e Don't print stack on CLI parsing failure or --help
refs #334
2021-08-10 13:22:04 +02:00
Eric Lippmann
0bf4f4df0a
Merge pull request #343 from Icinga/config-options
Separate required and optional configuration for database and Redis
2021-08-10 12:33:22 +02:00
Alexander Aleksandrovič Klimov
5a91d8acf6
Merge pull request #338 from Icinga/feature/support-icingadb-version-again-335
Support --version
2021-08-10 11:17:51 +02:00
Eric Lippmann
fbbb9bfacd Don't allow 0 for timeout redis option
0 stands for deactivate, which makes no sense here.
2021-08-10 09:29:27 +02:00
Eric Lippmann
8232000524 Don't allow 0 for max_connections database option
0 stands for deactivate, which makes no sense here.
2021-08-10 08:55:24 +02:00
Eric Lippmann
50473bca70 Remove UnmarshalYAML
Config options are no longer inlined.
2021-08-09 22:06:55 +02:00
Eric Lippmann
1c386c9c2f Don't inline Database options
There is now the options key to separate required and optional
configuration. Before, both were mixed.
2021-08-09 22:06:50 +02:00
Eric Lippmann
8927e942f1 Remove UnmarshalYAML
Config options are no longer inlined.
2021-08-09 22:06:50 +02:00
Eric Lippmann
559b27cd8b Don't inline Redis options
There is now the options key to separate required and optional
configuration. Before, both were mixed.
2021-08-09 21:48:27 +02:00
Eric Lippmann
f9e12d9df7 Move method 2021-08-09 21:45:08 +02:00
Alexander A. Klimov
825dcbc817 Introduce downtime#scheduled_by 2021-08-09 20:12:10 +02:00
Eric Lippmann
783b3a6bfe
Merge pull request #323 from Icinga/feature/downtime-parent-downtime-id
Downtime: Add parent_id
2021-08-09 13:43:16 +02:00
dependabot[bot]
95cc03d214
Bump github.com/go-redis/redis/v8 from 8.11.1 to 8.11.2
Bumps [github.com/go-redis/redis/v8](https://github.com/go-redis/redis) from 8.11.1 to 8.11.2.
- [Release notes](https://github.com/go-redis/redis/releases)
- [Changelog](https://github.com/go-redis/redis/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-redis/redis/compare/v8.11.1...v8.11.2)

---
updated-dependencies:
- dependency-name: github.com/go-redis/redis/v8
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-09 10:01:25 +00:00
Eric Lippmann
b1ec497c2b
Merge pull request #299 from Icinga/code-quality
Code quality
2021-08-09 10:41:20 +02:00
Eric Lippmann
0a521a6e4a Add missing doc in meta 2021-08-09 10:30:53 +02:00
Eric Lippmann
1d5ae198aa Add missing doc in meta 2021-08-09 10:30:53 +02:00
Eric Lippmann
a4b77c6a45 Add missing doc in sync 2021-08-09 10:30:53 +02:00
Eric Lippmann
77ab2753f9 Add missing doc in ha 2021-08-09 10:30:53 +02:00
Eric Lippmann
ac0f26e59b Add missing doc in entitiesbyid 2021-08-09 10:30:53 +02:00
Eric Lippmann
1d361594ee Add missing doc in dump_signals 2021-08-09 10:30:53 +02:00
Eric Lippmann
fc5e2882ff Add missing doc in delta 2021-08-09 10:30:53 +02:00
Eric Lippmann
1fda4ea6ee Rename start() to run() 2021-08-09 10:30:53 +02:00
Eric Lippmann
a13788073d Add missing doc entitiy_bulker 2021-08-09 10:30:53 +02:00
Eric Lippmann
2c3a58e365 Add missing doc in bulker 2021-08-09 10:30:53 +02:00
Eric Lippmann
bf415f2e1c Add missing doc in stats_message 2021-08-09 10:30:53 +02:00
Eric Lippmann
ff88cb73f7 Add missing doc in icinga_status 2021-08-09 10:30:53 +02:00
Eric Lippmann
92bc1b26c7 Add missing doc in redis utils 2021-08-09 10:30:53 +02:00
Eric Lippmann
fee30380d5 Add missing doc in client 2021-08-09 10:30:53 +02:00
Eric Lippmann
7d59a98f90 Add missing doc in utils 2021-08-09 10:30:53 +02:00
Eric Lippmann
d1c20b6946 Add missing doc in db 2021-08-09 10:30:53 +02:00
Eric Lippmann
4977d8f1f4 Add missing doc in command 2021-08-09 10:30:53 +02:00
Eric Lippmann
ffd66c5333 Add newline before return 2021-08-09 10:30:53 +02:00
Eric Lippmann
270f1930aa Remove useless comments 2021-08-09 10:30:53 +02:00
Eric Lippmann
7bda89e79d Return error instead of panicking 2021-08-09 10:29:47 +02:00
Eric Lippmann
ee36691f3f Remove --datadir config flag
It's currently not used anywhere.
2021-08-09 10:29:47 +02:00
Eric Lippmann
858dbe7481 Remove config.ValidateFile()
YAML already complains that the file is a directory:
"can't parse YAML file pkg: yaml: input error: read pkg: is a directory"
2021-08-09 10:29:47 +02:00
Eric Lippmann
0b1610c69b Use cancelCtx() instead of just cancel() 2021-08-09 10:29:47 +02:00
Eric Lippmann
f3f07a29cc Always use data as paramter name in UnmarshalJSON() 2021-08-09 10:29:47 +02:00
Eric Lippmann
63b8d98237 Always use text as paramter name in UnmarshalText() 2021-08-09 10:29:47 +02:00
Eric Lippmann
42935ae962 Fix comments 2021-08-09 10:29:47 +02:00
Eric Lippmann
83866f3a70 Remove unused variables Yes and No 2021-08-09 10:29:47 +02:00
Eric Lippmann
ec70babc91 Fix typo 2021-08-09 10:29:47 +02:00
Eric Lippmann
d40768ee64 Fix different receiver names 2021-08-09 10:29:47 +02:00
Eric Lippmann
e1d27bd93f Remove unused function PipeError 2021-08-09 10:29:47 +02:00
Eric Lippmann
f7be60623c Use QueryxContext() instead of Query() 2021-08-09 10:29:47 +02:00