From c2b449d3a65b8d0e8b68bd874ed3582e6f5d37aa Mon Sep 17 00:00:00 2001 From: Eric Lippmann Date: Tue, 9 Apr 2024 15:57:59 +0200 Subject: [PATCH] `HA`: Don't log retry count Logging of the `attempt` is a meaningless metric as it is not constantly logged but only when the retryable error changes, and it has no context as there is no such thing as max attempts. --- pkg/icingadb/ha.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/icingadb/ha.go b/pkg/icingadb/ha.go index 9830e4cc..a6355f31 100644 --- a/pkg/icingadb/ha.go +++ b/pkg/icingadb/ha.go @@ -394,7 +394,7 @@ func (h *HA) realize( log = h.logger.Infow } - log("Can't update or insert instance. Retrying", zap.Error(err), zap.Uint64("retry count", attempt)) + log("Can't update or insert instance. Retrying", zap.Error(err)) } }, OnSuccess: func(elapsed time.Duration, attempt uint64, lastErr error) {