From 7ba95af7b5dce14e0c514199571d16b2f433faa4 Mon Sep 17 00:00:00 2001 From: Alvar Penning Date: Tue, 14 Oct 2025 15:09:05 +0200 Subject: [PATCH] golangci-lint: Address sqlclosecheck The linter cannot handle icingadb-migrate. --- cmd/icingadb-migrate/main.go | 2 +- cmd/icingadb-migrate/misc.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/icingadb-migrate/main.go b/cmd/icingadb-migrate/main.go index af1254dd..09b225d5 100644 --- a/cmd/icingadb-migrate/main.go +++ b/cmd/icingadb-migrate/main.go @@ -397,7 +397,7 @@ func migrateOneType[IdoRow any]( var err error - lastStmt, err = ht.cache.Preparex(query) + lastStmt, err = ht.cache.Preparex(query) //nolint:sqlclosecheck // either closed in the if block above or in the defer func if err != nil { log.With("backend", "cache", "query", query). Fatalf("%+v", errors.Wrap(err, "can't prepare query")) diff --git a/cmd/icingadb-migrate/misc.go b/cmd/icingadb-migrate/misc.go index 5ee8b49c..818a258e 100644 --- a/cmd/icingadb-migrate/misc.go +++ b/cmd/icingadb-migrate/misc.go @@ -124,7 +124,7 @@ func sliceIdoHistory[Row any]( log.With("query", query).Fatalf("%+v", errors.Wrap(err, "can't perform query")) } - _ = stmt.Close() + _ = stmt.Close() //nolint:sqlclosecheck // no function exit between stmt creation and here, no reason for deferred close if len(rows) < 1 { break