Commit graph

2169 commits

Author SHA1 Message Date
Johannes Meyer
808a275b21
GitHub Actions: Add PHPStan (#423) 2023-09-05 14:56:09 +02:00
Sukhwinder Dhillon
7a9427ff11 State: Add phpDoc for properties and update phpstan baseline 2023-09-05 14:49:18 +02:00
Sukhwinder Dhillon
dd230a5458 Github Actions: Do not cancel further tests if one fails 2023-09-05 14:49:18 +02:00
Sukhwinder Dhillon
1fa4f3dbad Phpstan: Set level to max and add baseline file
- Remove already default flags in `max` level
2023-09-05 14:49:16 +02:00
Sukhwinder Dhillon
e4446e6068 UrlMigration: Remove unnecessary empty check 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
ad39b1125c Controller: PrintableHtmlDocument::setTitle() expects string as param 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
fe641e07ce CustomVarTable: Import missing class Closure 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
030fa3138b BaseHistoryListItem: Fix false positive 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
b1c844d52f Sni: Add variable type hint 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
d2f1a4dbde Add variable type hint to Icinga::app()'s returned object 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
239c33ade9 PerfData: Fix method name case 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
960c21d304 Create(Hosts/Services)SlaReport: Fix method name case 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
fce52f6b35 State: Add missing abstract methods 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
0ff9cca771 PerfDataTable: Respect given $limit 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
076fc02184 PerfDataTable: Simplify the code 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
922b09f7f1 PerfDataTable: Use strict comparison 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
57809e74ce PerfDataTable: Don't iterate unnecessarily 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
1863c7f55b PerfDataTable: Remove unnecessory property $containsSparkline
- Make it a method var
2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
2d195e0489 PerfDataTable: Remove unnecessary loop and $columns[] variable
- $columns[] is populated in loop, but never used
2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
7af6bb7e2c ObjectSuggestion: Fix incorrect variable type hint 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
8bcdb9ae3e Sni: Fix incorrect method name case 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
87f87283f4 SlaReport: Fix Variables '$interval, $boundry, $format' are probably undefined 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
a60ffe854b (Object(s)DetailExtension/ObjectAction)Hook: Fix incorrect var name in phpDoc 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
2365d6e64b ConpatObject: Fix method name case 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
a21e0d2443 IcingaRedis: Call private static methods with self instead of static 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
7c66c0ee20 IcingaRedis: Fix incorrect PhpDoc 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
7a3eefbb17 HostsController: Check ! $compact as in ServicesContoller 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
0e38493d5c Models: Fix method name case 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
e6a82567e5 PerfDataTable: Remove unnecessary if condition, $col is always set 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
bce9c53164 ObjectDetail: Fix Variable '$userQuery' is probably undefined 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
beffc0f9e3 DowntimeCard: Add $start, $end explicitly as non-dynamic property 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
61f689177b (Grid/View)ModeSwitcher: Fix Variable '$active, $inactive' are probably undefined 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
49a8455f19 VolatileStateResults::current(): Add required attribute #[\ReturnTypeWillChange] 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
807ef8402c CustomVarRendererHook: Remove not used param $object 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
2a26f28106 (Csv/Json)ResultSet::current(): Add phpDoc 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
106e7abc65 UrlMigration: Fix Variable '$modalPath, $exprRule' are probably undefined 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
5a64a83137 CommandActions: Fix Variable '$form' is probably undefined 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
d3c891578e RedisConfigForm: Fix Variable '$pem' is probably undefined 2023-09-05 14:26:42 +02:00
Sukhwinder Dhillon
78ffc0a8d0 Github Actions: Add PhpStan 2023-09-05 14:24:42 +02:00
Johannes Meyer
4714790b5d Use ipl\Stdlib\iterable_value_first to access the first item..
..a command has been transmitted for.
2023-09-05 09:16:56 +02:00
Yonas Habteab
423c9a88e4 Deprecate StateBadge class again 2023-08-29 09:27:11 +02:00
Sukhwinder Dhillon
aaf3a7b9f9 ObjectInspectionDetail: HtmlElement param#3 expects ValidHtml 2023-08-22 12:29:50 +02:00
Sukhwinder Dhillon
1aaa95e859 ObjectInspectionDetail: Render EmptyState message if $command is empty 2023-08-21 16:38:13 +02:00
Sukhwinder Dhillon
2eaf1e68f4 action-list.js: Use getAttribute to get href
- `.href` returns the whole url with `http(s)`.
2023-08-21 16:00:16 +02:00
Johannes Meyer
3aedccaad5 History: Sort also by type by default 2023-08-11 16:06:33 +02:00
Sukhwinder Dhillon
ba26dbe761 Controller::createColumnControl(): Make columns mandatory in tabular view mode 2023-08-11 16:01:29 +02:00
Yonas Habteab
ee7fa6e9fb Use modals for creating host/service reports 2023-08-11 16:00:53 +02:00
Johannes Meyer
7e9020aa67
action-list.js: Support key-navigation for table.action-list (#834) 2023-08-11 15:44:49 +02:00
Sukhwinder Dhillon
c7c60de76b action-list.js: Fix console error that [href] element is missing 2023-08-11 15:39:31 +02:00
Sukhwinder Dhillon
853cba8677 action-list.js: Optimize code 2023-08-11 15:39:31 +02:00