Commit graph

184 commits

Author SHA1 Message Date
Eric Lippmann
7bb09036fc Fix const visibility 2025-10-21 14:56:41 +02:00
Eric Lippmann
7fa28b9c9f Fix missing space after NOT operator 2025-10-21 14:56:41 +02:00
Ravi Kumar Kempapura Srinivasa
d0ffba3d91
ObjectSuggestions: Prioritze Column suggestions and best suggestions (#1215)
Show custom variable suggestions only if the column suggestions have not
consumed all the slots (50).

fixes #1206
2025-06-13 13:23:48 +02:00
Ravi Kumar Kempapura Srinivasa
cdfa388d16
ObjectSuggestion: Dynamically adjust columns and custom var suggestion limits (#1173)
Currently, the limit is globally set to 50, hence the short custom
variable names which overlaps with most of the column names will not be
suggested and instead only column names will be suggested. To prevent
this the default limit is split in half and adjusted dynamically based
on available suggestions.

resolves #1094
2025-05-12 14:11:23 +02:00
Johannes Meyer
04b8e220fd usergroup: Rename to contactgroup 2025-04-10 15:04:41 +02:00
Johannes Meyer
19135bcceb user: Rename to contact 2025-04-10 15:04:41 +02:00
Sukhwinder Dhillon
0ea3b63458 Controller: Remove obsolete if condition
Ipl-web manages this now
2025-03-28 16:13:17 +01:00
Sukhwinder Dhillon
793aa2414c ObjectSuggestions: Don't apply base filter to $customVars query
The basefilter may contain relations, that are not know to `CustomvarFlat`, which can leads to errors.
    For example: RedundancygroupController:completeActions's base filter is not known to `CustomvarFlat`.
2025-01-22 10:26:39 +01:00
Sukhwinder Dhillon
481dac43f9 ObjectSuggestions: Add methods to restrict $customVarSources 2025-01-20 10:50:18 +01:00
Johannes Meyer
a4a30c1a01 ObjectSuggestions: Support more base filters than restrictions 2024-07-19 14:24:14 +02:00
Johannes Meyer
0240cc437d Controller: Properly reset the default query limit during exports 2024-03-22 15:05:25 +01:00
Johannes Meyer
fbc37786ed Controller: Serve JSON if accepted
fixes #988
2024-03-22 14:30:13 +01:00
Johannes Meyer
8c13f5bfb0 ProblemsBadge: Don't return a string where only integers are expected
fixes #948
2024-03-22 13:52:20 +01:00
Johannes Meyer
20d9f8b712 Action: Don't attempt to resolve macros without an object
fixes #999
2024-03-22 13:50:45 +01:00
Johannes Meyer
ecb512620c Only qualify base columns during quick searches
All other columns are already qualified relative to the
base model. This is usually sufficient because qualification
is only required if applied to a query, which isn't happening
at this stage.

fixes #979
2024-03-14 15:35:18 +01:00
Johannes Meyer
2d85d98259 Controller: Preserve only selected search request parameters
fixes #887
2023-09-28 09:06:20 +02:00
Johannes Meyer
959f06cafd Utilize ipl\Web\Url::setFilter() where applicable 2023-09-12 09:52:19 +02:00
Yonas Habteab
705a470a1f Utilize widgets moved to ipl-web 2023-09-08 14:54:47 +02:00
Yonas Habteab
b17c30632d Fix failed to resolve reversed host/service -> comment relations 2023-09-05 18:06:02 +02:00
Sukhwinder Dhillon
ad39b1125c Controller: PrintableHtmlDocument::setTitle() expects string as param 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
d2f1a4dbde Add variable type hint to Icinga::app()'s returned object 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
7af6bb7e2c ObjectSuggestion: Fix incorrect variable type hint 2023-09-05 14:26:43 +02:00
Sukhwinder Dhillon
61f689177b (Grid/View)ModeSwitcher: Fix Variable '$active, $inactive' are probably undefined 2023-09-05 14:26:43 +02:00
Yonas Habteab
423c9a88e4 Deprecate StateBadge class again 2023-08-29 09:27:11 +02:00
Sukhwinder Dhillon
ba26dbe761 Controller::createColumnControl(): Make columns mandatory in tabular view mode 2023-08-11 16:01:29 +02:00
Johannes Meyer
121071c7f2 Revert "Drop classes StateBadge and StateBadges"
This reverts commit 6d36b0c3ed.
2023-07-20 09:36:36 +02:00
Yonas Habteab
96470ea243 Fix customvar search suggestions 2023-07-05 14:05:53 +02:00
Johannes Meyer
d9d3c074fb ObjectSuggestions: Don't split custom var paths more than once 2023-07-05 13:51:05 +02:00
raviks789
b1654ee0e0 Use BaseTableRowItem for HostgroupGridCell and ServicegroupGridCell 2023-06-20 13:39:53 +02:00
raviks789
cc02853f54 Use GridViewModeSwitcher for host and service groups
host and service groups need `GridViewModeSwitcher` to toggle between
list and grid view.
2023-06-20 13:39:53 +02:00
raviks789
9a409f0f87 Add GridViewModeSwitcher to toggle between list and grid view
Host and service groups need to toggle between grid and list view.
Hence, a new view mode switcher for this case has been created.
2023-06-20 13:39:53 +02:00
Yonas Habteab
b7c19c5a52 Controller: Set redirectUrl to grid action when rendering Host/Servicegroups & switching to minimal 2023-06-20 13:39:53 +02:00
Johannes Meyer
c193b51b7f Controller: Drop create*Control methods
They're now in the base class
2023-06-15 15:54:00 +02:00
Johannes Meyer
6d36b0c3ed Drop classes StateBadge and StateBadges
They're now part of ipl-web
2023-06-15 15:48:46 +02:00
Johannes Meyer
5303abe51c Use css grid instead of table layout for the hostgroup list 2023-06-07 10:53:44 +02:00
Johannes Meyer
389cc2ff57 Merge BaseItemTable into StateItemTable 2023-06-07 10:53:44 +02:00
Johannes Meyer
f28fd6a155 ObjectSuggestions: Suggest notificationcommand columns 2023-05-31 16:08:50 +02:00
Sukhwinder Dhillon
f675d539f2
Enhance global search (#756)
* Controllers: Remove not required method call `handleSearchRequest()`

These controller do not support global search

* Models: Add `display_name` to default search columns

* Controller: Add ´$additionaColumns` param to method handleSearchRequest() and prepareSearchFilter()

* TacticalController: Remove superfluous override of method `prepareSearchFilter()`
2023-05-30 15:26:00 +02:00
Johannes Meyer
0ac7fd1de5 Controller: Outsource filter construction in method handleSearchRequest()
Makes it possible for controllers to make their own adjustments.
2022-08-22 16:27:01 +02:00
Johannes Meyer
87cda9c1a6 ObjectSuggestions: Properly qualify search columns
Also uses the more flexible way of retrieving column definitions now.
2022-08-22 16:19:11 +02:00
Johannes Meyer
233609f5a3 Controller: Qualify search columns 2022-08-22 16:19:11 +02:00
Johannes Meyer
8f462c6a28 ObjectSuggestions: Only suggest cols of selected hasOne relations
The `isHasOne` check was made as the ipl-orm couldn't have known
about specific relations. The relation collection is now part of
this module so it can decide based on the name whether to collect
one or not.

fixes #534
2022-07-13 16:09:24 +02:00
Johannes Meyer
ce42a4b34a ObjectSuggestions: Also hide id columns 2022-07-13 16:09:24 +02:00
Johannes Meyer
87b66b11f0 ObjectSuggestions: Implement method shouldShowRelationFor() 2022-07-13 16:09:24 +02:00
Johannes Meyer
9159ff3c6c ObjectSuggestions: Remove suffixes from user and usergroup columns 2022-07-11 17:31:01 +02:00
raviks789
7368f87c04 ObjectSuggestions: Fix that group columns are not suggested
Also a fixes that some columns are shown repeatedly.

fixes #571
refs #556
2022-06-29 16:55:34 +02:00
Johannes Meyer
eee4a81d2e Introduce new widget base class BaseItemTable 2022-06-09 16:26:27 +02:00
Johannes Meyer
b4b1fffe18 Controller: Add new method createColumnControl() 2022-06-09 16:26:27 +02:00
Johannes Meyer
07e2341aea ViewModeSwitcher: Allow to change the mode programmatically 2022-06-09 16:26:27 +02:00
Johannes Meyer
822553e364 ViewModeSwitcher: Add basic support for mode tabular 2022-06-09 16:26:27 +02:00