This was easy because only README.md and doc/01-About.md were redacted manually, everything else via:
git ls-files -z |xargs -0 perl -pi -e 's/Icinga GmbH \| GPLv2/Icinga GmbH | GPLv2+/'
This is legal because we have only merged PRs with label:cla/signed or made by Icinga staff:
https://github.com/Icinga/icingadb-web/pulls?page=1&q=is%3Apr+is%3Aclosed+-label%3Acla%2Fsigned+-author%3Anilmerg
This has no risk for us in people distributing their own version under GPLv3 only.
After all, we won't take their patches anyway, unless they sign our CLA.
This is the cleanest solution for having e.g. these in one address space:
* Icinga Web, GPLv2+
* K8s Web, AGPLv3
* Thirdparty, some LGPLv3 and Apache-2.0
Apropos, K8s Web is even v3-licensed on purpose, to have a stronger protection against cloud ops.
Previously, command forms were responsible for this. But they
don't have any notion of fallback handling and are unable to
ensure proper re-submission of failed batches.
Reduces risk of timeouts in case Icinga takes its time to respond.
The timeout of 15 seconds introduced earlier has been kept.
Chunk sizes were chosen as follows:
- 1000: Cheap calculations (object features, check scheduling)
- 500: Expected disk writes (comments)
- 250: Process check result, Downtimes, Acks
I propose to add a new option for setting a default comment for
acknowledging problems (`acknowledge_comment_text`), similar to the
existing `hostdowntime_comment_text` and `servicedowntime_comment_text`
options.
This originally was a pull request for Icinga Web 2
(https://github.com/Icinga/icingaweb2/pull/5365). I was asked to
implement this in Icinga DB Web as well. *However, since I'm not using
Icinga DB Web myself, this is untested.*
Beside adding the new feature, I also fixed a copy-and-paste error for
the `servicedowntime_comment_text` option.
[hostdowntime_end_fixed], [hostdowntime_end_flexible], [hostdowntime_flexible_duration], [servicedowntime_end_fixed], [servicedwontime_end_flexible],
[servicedowntime_flexible_duration] and [comment_text] options added to [settings] section in config.ini file used in host/service downtime dialog.
* Command forms: Use strict interfaces to construct ipl\Html objects
* BaseTableRowItem: Use strict interfaces to create ipl\Html objects
* ObjectInspectionDetail: Use strict interfaces..
..to create ipl\Html objects
* Setup/*Step: Use strict interfaces to create ipl\Html objects
* ObjectSuggestions: Use strict interfaces to create ipl\Html objects
* Widget: Use strict interfaces to create ipl\Html objects
* Widget\Detail: Use strict interfaces to create ipl\Html objects
* Widget\ItemList: Use strict interfaces to create ipl\Html objects
* ServiceLink: Don't return an array
