upstream/icingadb-web
1
0
Fork 0
mirror of https://github.com/Icinga/icingadb-web.git synced 2026-05-28 04:36:06 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ObjectDetail: Only create a single CompatObject and re-use it

Browse source 
With `fetchCustomvars()` this class has now a proper state that
should be preserved in case it's required multiple times.
This commit is contained in:
Johannes Meyer 2020-04-03 16:06:43 +02:00
parent 60434fe15b
commit dd1d5bb7a1
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
library/Icingadb/Widget/Detail/ObjectDetail.php
View file

@ -43,6 +43,8 @@ class ObjectDetail extends BaseHtmlElement
protected $object;
protected $compatObject;
protected $objectType;
protected $defaultAttributes = ['class' => 'host-detail'];
@ -52,19 +54,19 @@ class ObjectDetail extends BaseHtmlElement
public function __construct($object)
{
$this->object = $object;
$this->compatObject = CompatObject::fromModel($object);
$this->objectType = $object instanceof Host ? 'host' : 'service';
}
protected function createActions()
{
$compatObject = CompatObject::fromModel($this->object);
$navigation = new Navigation();
$navigation->load($this->objectType . '-action');
foreach ($navigation as $item) {
$item->setObject($compatObject);
$item->setObject($this->compatObject);
}
foreach ($compatObject->getActionUrls() as $i => $url) {
foreach ($this->compatObject->getActionUrls() as $i => $url) {
$navigation->addItem(
'Action ' . ($i + 1),
[
@ -80,7 +82,7 @@ class ObjectDetail extends BaseHtmlElement
/** @var ObjectActionsHook $hook */
foreach (Hook::all('Monitoring\\' . ucfirst($this->objectType) . 'Actions') as $hook) {
$navigation->merge($hook->getNavigation($compatObject));
$navigation->merge($hook->getNavigation($this->compatObject));
}
if ($navigation->isEmpty() || ! $navigation->hasRenderableItems()) {
@ -210,11 +212,10 @@ class ObjectDetail extends BaseHtmlElement
protected function createNotes()
{
$compatObject = CompatObject::fromModel($this->object);
$navigation = new Navigation();
$notes = trim($this->object->notes);
foreach ($compatObject->getNotesUrls() as $i => $url) {
foreach ($this->compatObject->getNotesUrls() as $i => $url) {
$navigation->addItem(
'Notes ' . ($i + 1),
[