action-list.js: Don't add footer for list in .controls (#867)

fixes #866
This commit is contained in:
Johannes Meyer 2023-09-12 14:43:38 +02:00 committed by GitHub
commit 84eeeaa57d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 2 deletions

View file

@ -168,6 +168,7 @@ class HostsController extends Controller
$this->addControl(
(new HostList($results))
->setViewMode('minimal')
->setDetailActionsDisabled()
);
$this->addControl(new ShowMore(
$results,

View file

@ -184,6 +184,7 @@ class ServicesController extends Controller
$this->addControl(
(new ServiceList($results))
->setViewMode('minimal')
->setDetailActionsDisabled()
);
$this->addControl(new ShowMore(
$results,

View file

@ -133,7 +133,9 @@ trait DetailActions
public function addDetailFilterAttribute(BaseHtmlElement $element, Filter\Rule $filter): self
{
$element->getAttributes()
->set('data-action-item', true)
->registerAttributeCallback('data-action-item', function () {
return ! $this->getDetailActionsDisabled();
})
->registerAttributeCallback('data-icinga-detail-filter', function () use ($filter) {
return $this->getDetailActionsDisabled() ? null : QueryString::render($filter);
});

View file

@ -719,7 +719,7 @@
}
if (isTopLevelContainer) {
let footerList = list ?? container.querySelector('.action-list');
let footerList = list ?? container.querySelector('.content > .action-list');
if (footerList) {
_this.addSelectionCountToFooter(footerList);
}