upstream/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2026-06-09 08:42:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #10737 from Icinga/better-debug-message-non-existing-host-service-dep

Browse source 
Improve debug message when dependency child/parent don't exist
This commit is contained in:
Johannes Schmidt 2026-03-04 10:36:12 +01:00 committed by GitHub
commit e58947dc45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 30 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
lib/icinga/dependency.cpp
View file

@ -223,26 +223,46 @@ void Dependency::InitChildParentReferences()
Host::Ptr childHost = Host::GetByName(GetChildHostName());
if (childHost) {
if (GetChildServiceName().IsEmpty())
if (GetChildServiceName().IsEmpty()) {
m_Child = childHost;
else
} else {
m_Child = childHost->GetServiceByShortName(GetChildServiceName());
if (!m_Child) {
BOOST_THROW_EXCEPTION(ScriptError(
"Dependency '" + GetName() + "' references child service '" + GetChildServiceName() + "' on '" +
GetChildHostName() + "' which doesn't exist.",
GetDebugInfo()
));
}
}
} else {
BOOST_THROW_EXCEPTION(ScriptError(
"Dependency '" + GetName() + "' references child host '" + GetChildHostName() + "' which doesn't exist.",
GetDebugInfo()
));
}
if (!m_Child)
BOOST_THROW_EXCEPTION(ScriptError("Dependency '" + GetName() + "' references a child host/service which doesn't exist.", GetDebugInfo()));
Host::Ptr parentHost = Host::GetByName(GetParentHostName());
if (parentHost) {
if (GetParentServiceName().IsEmpty())
if (GetParentServiceName().IsEmpty()) {
m_Parent = parentHost;
else
} else {
m_Parent = parentHost->GetServiceByShortName(GetParentServiceName());
if (!m_Parent) {
BOOST_THROW_EXCEPTION(ScriptError(
"Dependency '" + GetName() + "' references parent service '" + GetParentServiceName() + "' on '" +
GetParentHostName() + "' which doesn't exist.",
GetDebugInfo()
));
}
}
} else {
BOOST_THROW_EXCEPTION(ScriptError(
"Dependency '" + GetName() + "' references parent host '" + GetParentHostName() + "' which doesn't exist.",
GetDebugInfo()
));
}
if (!m_Parent)
BOOST_THROW_EXCEPTION(ScriptError("Dependency '" + GetName() + "' references a parent host/service which doesn't exist.", GetDebugInfo()));
}
void Dependency::OnAllConfigLoaded()