upstream/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2026-05-28 04:12:13 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge c241546fed into f63bbec4ab

Browse source
This commit is contained in:
Julian Brost 2026-05-22 13:20:37 +02:00 committed by GitHub
commit a96a4a74f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/base/tlsutility.cpp
View file

@ -1049,7 +1049,7 @@ String BinaryToHex(const unsigned char* data, size_t length) {
static const char hexdigits[] = "0123456789abcdef";
String output(2*length, 0);
for (int i = 0; i < SHA_DIGEST_LENGTH; i++) {
for (size_t i = 0; i < length; i++) {
output[2 * i] = hexdigits[data[i] >> 4];
output[2 * i + 1] = hexdigits[data[i] & 0xf];
}

22
test/base-tlsutility.cpp
View file

@ -309,4 +309,26 @@ BOOST_FIXTURE_TEST_CASE(create_verify_leaf_certs, CertificateFixture,
ASSERT_SIGNATURE_FAILURE(cacert, StringToCertificate(CertificateToString(newCert)));
}
BOOST_AUTO_TEST_CASE(binary_to_hex)
{
using namespace std::string_view_literals;
// Helper to call with string_view and to cast from char to unsigned char.
auto f = [](std::string_view s) {
return BinaryToHex(reinterpret_cast<const unsigned char*>(s.data()), s.length());
};
// Hint: test data can be generated/verified with commands like this: printf ICINGA | xxd -p -c 0
BOOST_CHECK_EQUAL(f(""sv), "");
BOOST_CHECK_EQUAL(f("ICINGA"sv), "4943494e4741");
BOOST_CHECK_EQUAL(f("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"sv),
"6162636465666768696a6b6c6d6e6f707172737475767778797a4142434445464748494a4b4c4d4e4f505152535455565758595a");
BOOST_CHECK_EQUAL(f("handles\0correctly"sv), "68616e646c657300636f72726563746c79");
BOOST_CHECK_EQUAL(f("\0\0\0\0\0"sv), "0000000000");
// Long string of 10000 * 'D' (= 0x44) should become 10000 * '44' = 20000 * '4':
BOOST_CHECK_EQUAL(f(std::string(10000, 0x44)), std::string(20000, '4'));
}
BOOST_AUTO_TEST_SUITE_END()