upstream/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2026-07-15 03:41:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add tests for JsonDecode depth limit in combination with coroutine stacks

Browse source 
(cherry picked from commit 0481a66b01)
This commit is contained in:
Julian Brost 2026-06-09 15:09:13 +02:00
parent dfda80415d
commit 77effd5bbb
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
test/base-json.cpp
View file

@ -1,6 +1,7 @@
// SPDX-FileCopyrightText: 2012 Icinga GmbH <https://icinga.com>
// SPDX-License-Identifier: GPL-2.0-or-later
#include "base/convert.hpp"
#include "base/dictionary.hpp"
#include "base/function.hpp"
#include "base/namespace.hpp"
@ -8,6 +9,7 @@
#include "base/generator.hpp"
#include "base/objectlock.hpp"
#include "base/json.hpp"
#include "test/utils.hpp"
#include <boost/algorithm/string/replace.hpp>
#include <BoostTestTargetConfig.h>
#include <limits>
@ -269,4 +271,31 @@ BOOST_AUTO_TEST_CASE(decode_depth_limit)
BOOST_CHECK_NO_THROW(JsonDecode(deeperMixedNesting, 10));
}
/* This test case decodes JSON nested much deeper (see safetyFactor) than the default depth limit and performs some
* operations on the resulting values. This is done within a coroutine with its limited stack size on order to verify
* that the default limit is low enough to be safe. Note that this isn't an exact science unfortunately: other
* recursive operations may have larger stack frames and these operations aren't the only thing on a stack (could be
* done inside an HTTP or JSON-RPC connection for example). Therefor, aim for a sufficiently large safety factor.
*/
BOOST_AUTO_TEST_CASE(coroutine_stack_size)
{
auto future = SpawnSynchronizedCoroutine([](boost::asio::yield_context) {
constexpr size_t safetyFactor = 10;
constexpr size_t depth = JsonDecodeDefaultDepthLimit * safetyFactor;
Value val;
BOOST_REQUIRE_NO_THROW(val = JsonDecode(MakeNestedJsonArray(depth), depth));
BOOST_REQUIRE_NO_THROW(val.Clone());
BOOST_REQUIRE_NO_THROW(Convert::ToString(val));
BOOST_REQUIRE_NO_THROW(JsonDecode(JsonEncode(val), depth));
BOOST_REQUIRE_NO_THROW(val = JsonDecode(MakeNestedJsonObject(depth), depth));
BOOST_REQUIRE_NO_THROW(val.Clone());
BOOST_REQUIRE_NO_THROW(Convert::ToString(val));
BOOST_REQUIRE_NO_THROW(JsonDecode(JsonEncode(val), depth));
});
future.get();
}
BOOST_AUTO_TEST_SUITE_END()