From 5547488cd5a2bf45c23a3d5276371ae6d2b61864 Mon Sep 17 00:00:00 2001
From: "Alexander A. Klimov" <alexander.klimov@icinga.com>
Date: Fri, 27 Nov 2020 17:03:34 +0100
Subject: [PATCH] Introduce Checkable#NotificationReasonSuppressed()

refs #8509
---
 lib/icinga/checkable-notification.cpp | 40 +++++++++++++++------------
 lib/icinga/checkable.hpp              |  1 +
 2 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/lib/icinga/checkable-notification.cpp b/lib/icinga/checkable-notification.cpp
index 7d9fcb6b1..7bdfaa67c 100644
--- a/lib/icinga/checkable-notification.cpp
+++ b/lib/icinga/checkable-notification.cpp
@@ -173,24 +173,7 @@ static void FireSuppressedNotifications(Checkable* checkable)
 				bool still_applies = checkable->NotificationReasonApplies(type);
 
 				if (still_applies) {
-					bool still_suppressed;
-
-					switch (type) {
-						case NotificationProblem:
-							/* Fall through. */
-						case NotificationRecovery:
-							still_suppressed = !checkable->IsReachable(DependencyNotification) || checkable->IsInDowntime() || checkable->IsAcknowledged();
-							break;
-						case NotificationFlappingStart:
-							/* Fall through. */
-						case NotificationFlappingEnd:
-							still_suppressed = checkable->IsInDowntime();
-							break;
-						default:
-							break;
-					}
-
-					if (!still_suppressed && !checkable->IsLikelyToBeCheckedSoon() && !wasLastParentRecoveryRecent.Get()) {
+					if (!checkable->NotificationReasonSuppressed(type) && !checkable->IsLikelyToBeCheckedSoon() && !wasLastParentRecoveryRecent.Get()) {
 						Checkable::OnNotificationsRequested(checkable, type, checkable->GetLastCheckResult(), "", "", nullptr);
 
 						subtract |= type;
@@ -258,6 +241,27 @@ bool Checkable::NotificationReasonApplies(NotificationType type)
 	}
 }
 
+/**
+ * Returns whether *this not allows sending a notification of type type right now.
+ *
+ * @param type The type of notification to send (or not to send).
+ *
+ * @return Whether not to send the notification.
+ */
+bool Checkable::NotificationReasonSuppressed(NotificationType type)
+{
+	switch (type) {
+		case NotificationProblem:
+		case NotificationRecovery:
+			return !IsReachable(DependencyNotification) || IsInDowntime() || IsAcknowledged();
+		case NotificationFlappingStart:
+		case NotificationFlappingEnd:
+			return IsInDowntime();
+		default:
+			return false;
+	}
+}
+
 /**
  * E.g. we're going to re-send a stashed problem notification as *this is still not ok.
  * But if the next check result recovers *this soon, we would send a recovery notification soon after the problem one.
diff --git a/lib/icinga/checkable.hpp b/lib/icinga/checkable.hpp
index c9799f07a..97518cfc2 100644
--- a/lib/icinga/checkable.hpp
+++ b/lib/icinga/checkable.hpp
@@ -175,6 +175,7 @@ public:
 	void ValidateMaxCheckAttempts(const Lazy<int>& lvalue, const ValidationUtils& value) final;
 
 	bool NotificationReasonApplies(NotificationType type);
+	bool NotificationReasonSuppressed(NotificationType type);
 	bool IsLikelyToBeCheckedSoon();
 
 	static void IncreasePendingChecks();